Date: Sat, 27 Aug 2005 00:59:11 -0400 From: Brian Fundakowski Feldman <green@FreeBSD.org> To: Garance A Drosehn <gad@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Pawel Jakub Dawidek <pjd@FreeBSD.org>, cvs-all@FreeBSD.org, John Baldwin <jhb@FreeBSD.org> Subject: Re: cvs commit: src/usr.bin/pkill pkill.1 pkill.c Message-ID: <20050827045911.GB46755@green.homeunix.org> In-Reply-To: <p06230909bf329ce9de72@[128.113.24.47]> References: <200508241938.j7OJcSNW066686@repoman.freebsd.org> <200508241602.59424.jhb@FreeBSD.org> <20050824205627.GD755@garage.freebsd.pl> <p06230909bf329ce9de72@[128.113.24.47]>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 24, 2005 at 06:14:15PM -0400, Garance A Drosehn wrote: > At 10:56 PM +0200 8/24/05, Pawel Jakub Dawidek wrote: > >On Wed, Aug 24, 2005, John Baldwin wrote: > >+> On Wednesday 24 August 2005, Pawel Jakub Dawidek wrote: > >+> > Log: > >+> > Modify '-F' option to work nicely with pidfile(3) - a pidfile > >+> > given as an argument has to be locked. > >+> > > >+> > >+> I guess the only thing that makes me uncomfortable about this > >+> change is that it means pkill won't work with 3rd party program's > >+> pid files since they are probably not using pidfile(3). Maybe > >+> have some way of turning off the flock requirement? > > I must admit that I did not quite understand what you had meant in > your earlier messages about changes to `pkill' to match your new > pid-handling library routines. I agree with John, this change > doesn't seem quite right to me. What keeps an arbitrary user from locking the pid file and making a mess of this protocol? It seems less error prone to just make pkill verify the (pid, procname, uid, gid, pgrp) are all in line with what the pidfile implies... to me at least. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050827045911.GB46755>