Date: Thu, 27 Jul 2006 03:54:23 GMT From: Sam Leffler <sam@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 102518 for review Message-ID: <200607270354.k6R3sNL2014883@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=102518 Change 102518 by sam@sam_ebb on 2006/07/27 03:53:36 correct start+end order for pci irq's; something doesn't seem right though as the pci irq's overlap the full set of irq's setup elsewhere and we're using the same rman structure--maybe pci has it's own? Affected files ... .. //depot/projects/arm/src/sys/arm/xscale/ixp425/ixdp425_pci.c#4 edit Differences ... ==== //depot/projects/arm/src/sys/arm/xscale/ixp425/ixdp425_pci.c#4 (text+ko) ==== @@ -131,10 +131,11 @@ GPIO_CONF_WRITE_4(sc, IXP425_GPIO_GPOUTR, reg | (1U << GPIO_PCI_RESET)); sc->sc_irq_rman.rm_type = RMAN_ARRAY; sc->sc_irq_rman.rm_descr = "IXP425 PCI IRQs"; + CTASSERT(PCI_INT_D < PCI_INT_A); + /* XXX this overlaps the irq's setup in ixp425_attach */ if (rman_init(&sc->sc_irq_rman) != 0 || - rman_manage_region(&sc->sc_irq_rman, PCI_INT_A, PCI_INT_D) != 0) + rman_manage_region(&sc->sc_irq_rman, PCI_INT_D, PCI_INT_A) != 0) panic("ixp425_md_attach: failed to set up IRQ rman"); - } #define IXP425_MAX_DEV 4
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607270354.k6R3sNL2014883>