Date: Tue, 28 Sep 2010 19:26:17 +0000 From: "Sergey A. Osokin" <osa@FreeBSD.org> To: "David E. Thiel" <lx@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: [ports] cvs commit: ports/security/silktools pkg-plist Message-ID: <20100928192617.GG72615@FreeBSD.org> In-Reply-To: <20100928183505.GC2155@redundancy.redundancy.org> References: <201009281811.o8SIBs8B069790@repoman.freebsd.org> <20100928181158.4E4CE1065788@hub.freebsd.org> <20100928182233.GF72615@FreeBSD.org> <20100928183505.GC2155@redundancy.redundancy.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 28, 2010 at 11:35:30AM -0700, David E. Thiel wrote: > On Tue, Sep 28, 2010 at 06:22:09PM +0000, Sergey A. Osokin wrote: > > could you please: > > > > 1) test your changes before commit; > > 2) view the diff of your changes before commit. > > The changes were tested against my last update of the port, but a > double-check of the diff would have been a good idea. While I appreciate > the intent, it's rather unusual and counterproductive for someone to > immediately jump in and change someone's ports without asking. >From time to time I read QAT letters after bug commits by committers who do not test they changes before commit. But everyone of them sad I test my changes before commit. What did I do before commit my fix after your two bad commits ? 1) cvs co silktools 2) check and fix pkg-plist 3) run build, install, deinstall, package... 4) do cvs diff silktools (still no commit) 5) found more more issue (unsorted plist) 6) do step 4 again - no commit 7) commit changes Sorry if it was very fast for you - next time I'll do my trick for you slowly. -- Sergey A. Osokin osa@FreeBSD.ORG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100928192617.GG72615>