From owner-freebsd-rc@FreeBSD.ORG Thu Dec 1 07:20:09 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15E1F1065675; Thu, 1 Dec 2011 07:20:09 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id B19CB8FC17; Thu, 1 Dec 2011 07:20:08 +0000 (UTC) Received: by ywp17 with SMTP id 17so2391991ywp.13 for ; Wed, 30 Nov 2011 23:20:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=SrIYcjbP7YGKtltI363A1hF+8mMKLanf/UUsa7xpmXg=; b=Uq1hRZ6/HFnyQZ/dKY8CGBqszLZyWeDE/NCi7CYXOYQvLIhHAIQDSH6QgUGuz1ayLH T2NZbGpw/Q21YJkfTBSlL6Cm1P2yQtCGTXrFnbQwYq0QV6lbjdAgyCXhnjgB4wSQENp4 3qFNLOz5v+bXp2ivgHwLpDNvGrLC3ygBQw3qA= MIME-Version: 1.0 Received: by 10.182.172.41 with SMTP id az9mr1204819obc.42.1322724007918; Wed, 30 Nov 2011 23:20:07 -0800 (PST) Received: by 10.182.62.227 with HTTP; Wed, 30 Nov 2011 23:20:07 -0800 (PST) In-Reply-To: <4ED71CE1.2010101@FreeBSD.org> References: <4ED66DCB.1040102@yandex.ru> <4ED67B8F.50109@yandex.ru> <4ED6BE87.4060408@FreeBSD.org> <4ED71CE1.2010101@FreeBSD.org> Date: Wed, 30 Nov 2011 23:20:07 -0800 Message-ID: From: Garrett Cooper To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-rc@freebsd.org, Ruslan Mahmatkhanov Subject: Re: rc-script review request X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2011 07:20:09 -0000 On Wed, Nov 30, 2011 at 10:21 PM, Doug Barton wrote: > On 11/30/2011 17:14, Garrett Cooper wrote: >> =A0 =A0 Crazy thought -- should a script be made for rc scripts, similar >> to portcheck? I meant portlint, BTW.. not portcheck :). > I look forward to reviewing your patches to implement this feature. :) Yipes... I have some work ahead of me. portlink is 3k lines of perlness... > Seriously though, I've thought about it, but the problem is that the > number of variables is really high, and unlike port Makefiles there are > very few standard elements that exist in a predetermined order. Well, yeah.. you can't catch everything, but it wouldn't hurt to catch basic issues so you wouldn't have to be bothered to review first drafts of code. > OTOH, I'd be happy to be proven wrong. Thanks! -Garrett