Date: Tue, 26 Mar 2019 20:59:08 -0600 From: Alan Somers <asomers@freebsd.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-projects@freebsd.org Subject: Re: svn commit: r345563 - projects/fuse2/tests/sys/fs/fusefs Message-ID: <CAOtMX2g8H90ehyt4JfHo=8yT2q9ESNHWgo7HYx67Ma3Ou=U%2BwA@mail.gmail.com> In-Reply-To: <43ACF554-1D64-4CDE-AB22-8A13E3585CC9@gmail.com> References: <201903270024.x2R0Ov1e073868@repo.freebsd.org> <43ACF554-1D64-4CDE-AB22-8A13E3585CC9@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 26, 2019 at 8:39 PM Enji Cooper <yaneurabeya@gmail.com> wrote: > > > On Mar 26, 2019, at 5:24 PM, Alan Somers <asomers@FreeBSD.org> wrote: > > Author: asomers > Date: Wed Mar 27 00:24:57 2019 > New Revision: 345563 > URL: https://svnweb.freebsd.org/changeset/base/345563 > > Log: > fusefs: fix a race condition in the allow_other test > > The test could occasionally hang if the parent's SIGUSR2 signal arrived > before the child had pause()d. Using POSIX semaphores precludes that > possibility. > > Sponsored by: The FreeBSD Foundation > > > =E2=80=A6 > > + sem =3D (sem_t*)mmap(NULL, sizeof(*sem), mprot, mflags, -1, 0); > + ASSERT_NE(NULL, sem) << strerror(errno); > > > mmap will return =E2=80=9CMAP_FAILED=E2=80=9D, not NULL, on error. > > Thanks, > -Enji Whoops! Good catch.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2g8H90ehyt4JfHo=8yT2q9ESNHWgo7HYx67Ma3Ou=U%2BwA>