From owner-cvs-all Tue Jan 8 9:42:51 2002 Delivered-To: cvs-all@freebsd.org Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by hub.freebsd.org (Postfix) with ESMTP id 630AF37B41A for ; Tue, 8 Jan 2002 09:42:37 -0800 (PST) Received: (qmail 26170 invoked from network); 8 Jan 2002 17:42:36 -0000 Received: from unknown (HELO server.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail5.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 8 Jan 2002 17:42:36 -0000 Received: from laptop.baldwin.cx (root@laptop.baldwin.cx [192.168.0.4]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g08HgaK52753; Tue, 8 Jan 2002 09:42:36 -0800 (PST) (envelope-from john@laptop.baldwin.cx) Received: (from john@localhost) by laptop.baldwin.cx (8.11.6/8.11.6) id g08Hg2m01796; Tue, 8 Jan 2002 09:42:02 -0800 (PST) (envelope-from john) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020108152405.A83902@ark.cris.net> Date: Tue, 08 Jan 2002 09:42:01 -0800 (PST) From: John Baldwin To: Alexey Zelkin Subject: Re: cvs commit: src/usr.bin/colldef Makefile Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Sheldon Hearn Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 08-Jan-02 Alexey Zelkin wrote: > On Tue, Jan 08, 2002 at 03:14:06PM +0200, Sheldon Hearn wrote: >> >> >> On Tue, 08 Jan 2002 03:08:20 PST, John Baldwin wrote: >> >> > Modified files: >> > usr.bin/colldef Makefile >> > Log: >> > Replace -I${.OBJDIR} with -I. and split the CFLAGS line up into two >> > lines. >> >> Why '.' and not '${.CURDIR}'? I'm sure I'm not the only one who'd >> benefit from an explanation. > > Because -I${.CURDIR} is already in CFLAGS (see previous revision) > and since colldef is using automatically generated .h file it requires > -I${.OBJDIR} or -I. to find pregenerated y.tab.h. > > Looks like this commit is a style fix. Basically. -I. is -I${.OBJDIR} since make runs commands with ${.OBJDIR} as the current directory (AFAICT) rather than ${.CURDIR} in the case that there is an object directory. (If there isn't one, ${.OBJDIR} == ${.CURDIR}). Given that, -I. is a lot shorter and easier on the eyes then -I${.OBJDIR}, although I personally find it a bit more cryptic since it relies on you grokking the make behavior of changing the current directroy to make object directories work. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message