Date: Mon, 01 Jun 2009 19:52:24 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: "M. Warner Losh" <imp@bsdimp.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, rse@FreeBSD.org Subject: Re: svn commit: r193223 - head/bin/sh Message-ID: <86vdnfq1t3.fsf@ds4.des.no> In-Reply-To: <20090601.104358.-345495454.imp@bsdimp.com> (M. Warner Losh's message of "Mon, 01 Jun 2009 10:43:58 -0600 (MDT)") References: <200906011111.n51BBkZt077175@svn.freebsd.org> <20090601.104358.-345495454.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"M. Warner Losh" <imp@bsdimp.com> writes:
> : @@ -187,7 +187,8 @@ padvance(char **path, char *name)
> : if (*path =3D=3D NULL)
> : return NULL;
> : start =3D *path;
> : - for (p =3D start ; *p && *p !=3D ':' && *p !=3D '%' ; p++);
> : + for (p =3D start; *p && *p !=3D ':' && *p !=3D '%'; p++)
> : + ; /* nothing */
>
> C already has a way of saying this:
>
> for (p =3D start; *p && *p !=3D ':' && *p !=3D '%'; p++)
> contionue;
It's a matter of taste. There is plenty of precedent for
/* nothing */ ;
and some for
; /* nothing */
(for varying spellings of "nothing") in the tree.
DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86vdnfq1t3.fsf>