From owner-svn-src-head@FreeBSD.ORG  Mon Jun  1 17:52:25 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ADD82106566C;
	Mon,  1 Jun 2009 17:52:25 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 6B1538FC1A;
	Mon,  1 Jun 2009 17:52:25 +0000 (UTC) (envelope-from des@des.no)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id 4B4356D41D;
	Mon,  1 Jun 2009 19:52:24 +0200 (CEST)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 26CE9844CC; Mon,  1 Jun 2009 19:52:24 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: "M. Warner Losh" <imp@bsdimp.com>
References: <200906011111.n51BBkZt077175@svn.freebsd.org>
	<20090601.104358.-345495454.imp@bsdimp.com>
Date: Mon, 01 Jun 2009 19:52:24 +0200
In-Reply-To: <20090601.104358.-345495454.imp@bsdimp.com> (M. Warner Losh's
	message of "Mon, 01 Jun 2009 10:43:58 -0600 (MDT)")
Message-ID: <86vdnfq1t3.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, rse@FreeBSD.org
Subject: Re: svn commit: r193223 - head/bin/sh
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Jun 2009 17:52:26 -0000

"M. Warner Losh" <imp@bsdimp.com> writes:
> : @@ -187,7 +187,8 @@ padvance(char **path, char *name)
> :  	if (*path =3D=3D NULL)
> :  		return NULL;
> :  	start =3D *path;
> : -	for (p =3D start ; *p && *p !=3D ':' && *p !=3D '%' ; p++);
> : +	for (p =3D start; *p && *p !=3D ':' && *p !=3D '%'; p++)
> : +		; /* nothing */
>
> C already has a way of saying this:
>
> 	for (p =3D start; *p && *p !=3D ':' && *p !=3D '%'; p++)
> 		contionue;

It's a matter of taste.  There is plenty of precedent for

        /* nothing */ ;

and some for

        ; /* nothing */

(for varying spellings of "nothing") in the tree.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no