From owner-cvs-all Tue Jan 16 14:48:29 2001 Delivered-To: cvs-all@freebsd.org Received: from mailgate.originative.co.uk (mailgate.originative.co.uk [62.232.68.68]) by hub.freebsd.org (Postfix) with ESMTP id BF10837B404; Tue, 16 Jan 2001 14:48:06 -0800 (PST) Received: from freebsd-services.co.uk (tiddler.originative.co.uk [62.232.68.83]) by mailgate.originative.co.uk (Postfix) with ESMTP id 3270B1D140; Tue, 16 Jan 2001 22:48:05 +0000 (GMT) Message-ID: <3A64D05A.ABFD3322@freebsd-services.co.uk> Date: Tue, 16 Jan 2001 22:51:06 +0000 From: Paul Richards Organization: FreeBSD Services Ltd X-Mailer: Mozilla 4.75 [en] (X11; U; Linux 2.2.12 i386) X-Accept-Language: en MIME-Version: 1.0 To: Josef Karthauser Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_stats.c References: <200101142333.f0ENXqB09391@freefall.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Josef Karthauser wrote: > > joe 2001/01/14 15:33:51 PST > > Modified files: > sys/compat/linux linux_stats.c > Log: > Instead of hard coding the major numbers for IDE and SCSI disks > look in the device's cdevsw for the D_DISK flag. Ahh, I didn't commit this because it's not just IDE and SCSI disks that have D_DISK set. CDROM's also have it set, as do md and vn devices and I wasn't sure that they should be remapped in the same way as IDE and SCSI disks, particularly the mapping of the major number to 0, which I wasn't even sure was right for SCSI disks. I think what is needed is a more generic solution, such as a table that maps FreeBSD devices to Linux devices as appropriate. Paul. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message