From owner-freebsd-ports Wed Mar 21 7:43:20 2001 Delivered-To: freebsd-ports@freebsd.org Received: from blizzard.sabbo.net (ns.sabbo.net [193.193.218.18]) by hub.freebsd.org (Postfix) with ESMTP id 13FFB37B72D for ; Wed, 21 Mar 2001 07:43:06 -0800 (PST) (envelope-from sobomax@FreeBSD.org) Received: from vic.sabbo.net (root@vic.sabbo.net [193.193.218.112]) by blizzard.sabbo.net (8.10.1/8.10.1) with ESMTP id f2LFfrj08582; Wed, 21 Mar 2001 17:42:01 +0200 Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vic.sabbo.net (8.11.3/8.11.2) with ESMTP id f2LFfre69398; Wed, 21 Mar 2001 17:41:53 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Message-ID: <3AB8CBD2.6D972527@FreeBSD.org> Date: Wed, 21 Mar 2001 17:42:10 +0200 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.76 [en] (WinNT; U) X-Accept-Language: uk,ru,en MIME-Version: 1.0 To: Will Andrews Cc: FreeBSD Ports Subject: Re: bsd.kdeqt.mk References: <20010321095815.X469@ohm.physics.purdue.edu> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Will Andrews wrote: > Hello guys, > > Given the rapid rise in complexity recently with KDE/QT stuff, I decided > last night to take another shot at bsd.kdeqt.mk. Here are the diffs. > Could Satoshi please put these in the cluster at some point, so that at > least the mechanism in which the USE_QT* stuff is checked? Then I can > handle the rest of the outsourcing. > > Suggestions on how to improve it would be most welcome. They are based > on what I've got in my tree currently, and depend on the PTHREAD_* patch > to bsd.port.mk that Satoshi has in the build cluster currently. Looks fine to me. Small suggestions: IMO it is better to add KDE_VERSION (defaulting to 2) and use unified USE_KDEBASE/LIBS without trailing version number. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message