From owner-cvs-src@FreeBSD.ORG Sat Sep 27 05:01:03 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E60A16A4BF; Sat, 27 Sep 2003 05:01:03 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A3FAC43FA3; Sat, 27 Sep 2003 05:01:01 -0700 (PDT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id h8RC11XJ029296; Sat, 27 Sep 2003 05:01:01 -0700 (PDT) (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.9/8.12.9/Submit) id h8RC11VZ029295; Sat, 27 Sep 2003 05:01:01 -0700 (PDT) (envelope-from phk) Message-Id: <200309271201.h8RC11VZ029295@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 27 Sep 2003 05:01:01 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/adlink adlink.c src/sys/dev/ata ata-all.c src/sys/dev/isp isp_freebsd.c src/sys/dev/md md.c src/sys/dev/null null.c src/sys/dev/ofw openfirmio.c src/sys/geom geom_ctl.c src/sys/i386/bios smapi.c src/sys/i386/i386 elan-mmcr.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Sep 2003 12:01:03 -0000 phk 2003/09/27 05:01:01 PDT FreeBSD src repository Modified files: sys/dev/adlink adlink.c sys/dev/ata ata-all.c sys/dev/isp isp_freebsd.c sys/dev/md md.c sys/dev/null null.c sys/dev/ofw openfirmio.c sys/geom geom_ctl.c sys/i386/bios smapi.c sys/i386/i386 elan-mmcr.c sys/kern kern_conf.c subr_devstat.c tty_tty.c sys/netncp ncp_mod.c sys/opencrypto cryptodev.c Log: The present defaults for the open and close for device drivers which provide no methods does not make any sense, and is not used by any driver. It is a pretty hard to come up with even a theoretical concept of a device driver which would always fail open and close with ENODEV. Change the defaults to be nullopen() and nullclose() which simply does nothing. Remove explicit initializations to these from the drivers which already used them. Revision Changes Path 1.6 +0 -1 src/sys/dev/adlink/adlink.c 1.190 +0 -2 src/sys/dev/ata/ata-all.c 1.94 +0 -2 src/sys/dev/isp/isp_freebsd.c 1.106 +0 -2 src/sys/dev/md/md.c 1.20 +0 -4 src/sys/dev/null/null.c 1.7 +0 -2 src/sys/dev/ofw/openfirmio.c 1.30 +0 -2 src/sys/geom/geom_ctl.c 1.8 +0 -2 src/sys/i386/bios/smapi.c 1.18 +0 -2 src/sys/i386/i386/elan-mmcr.c 1.135 +2 -2 src/sys/kern/kern_conf.c 1.47 +0 -2 src/sys/kern/subr_devstat.c 1.51 +0 -1 src/sys/kern/tty_tty.c 1.11 +0 -2 src/sys/netncp/ncp_mod.c 1.15 +0 -1 src/sys/opencrypto/cryptodev.c