From owner-freebsd-net@freebsd.org  Mon Jun 20 10:54:00 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A8075A7BB34
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Mon, 20 Jun 2016 10:54:00 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3])
 by mx1.freebsd.org (Postfix) with ESMTP id 942F727E0
 for <freebsd-net@freebsd.org>; Mon, 20 Jun 2016 10:54:00 +0000 (UTC)
 (envelope-from hps@selasky.org)
Received: by mailman.ysv.freebsd.org (Postfix)
 id 8D461A7BB32; Mon, 20 Jun 2016 10:54:00 +0000 (UTC)
Delivered-To: net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8A4EBA7BB30;
 Mon, 20 Jun 2016 10:54:00 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4714927DB;
 Mon, 20 Jun 2016 10:53:59 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id B98351FE023;
 Mon, 20 Jun 2016 12:53:57 +0200 (CEST)
Subject: Re: panic with tcp timers
To: Gleb Smirnoff <glebius@FreeBSD.org>
References: <20160617045319.GE1076@FreeBSD.org>
 <1f28844b-b4ea-b544-3892-811f2be327b9@freebsd.org>
 <20160620073917.GI1076@FreeBSD.org>
 <1d18d0e2-3e42-cb26-928c-2989d0751884@freebsd.org>
 <20160620095822.GJ1076@FreeBSD.org>
 <b81aa248-4b97-3162-7636-da655163cdcc@selasky.org>
 <20160620103015.GK1076@FreeBSD.org>
Cc: Julien Charbon <jch@freebsd.org>, rrs@FreeBSD.org, net@FreeBSD.org,
 current@FreeBSD.org
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <df07d096-fed6-e098-6ae2-b8333dd59901@selasky.org>
Date: Mon, 20 Jun 2016 12:57:35 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <20160620103015.GK1076@FreeBSD.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jun 2016 10:54:00 -0000

On 06/20/16 12:30, Gleb Smirnoff wrote:
> Exactly! I am convinced that all callouts should be locked, and non-locked
> one should simply go away, as well as async drain.

I agree about that that, except you still need the async drain, because 
it will prevent freeing the lock protecting the callout, which may still 
be in use after callout_stop().

--HPS