From owner-svn-ports-all@freebsd.org Mon Nov 16 03:11:12 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D6B7A30016; Mon, 16 Nov 2015 03:11:12 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-oi0-x232.google.com (mail-oi0-x232.google.com [IPv6:2607:f8b0:4003:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C4E831191; Mon, 16 Nov 2015 03:11:11 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by oixx65 with SMTP id x65so65320884oix.0; Sun, 15 Nov 2015 19:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=+TAcP4EE1Lk+ikgndjF2p1faztUqFkTyPriRLb17U+4=; b=C2FGe36iZs7COCgsNSy2r9bonhj0txf+Hft740cMYUFMqV8rMjpHIMTxD/X5oy0jGV OWQO2sR6AqNaVAoUAYgNt/z/qiAX3xypfJdNa7xCAhfIPQxwJI/NctNp1zCG2Bi+NkwY C+JD/F/bpzLuh8tmMA+zNpk02BxrCxvuP3JmpZUuguYi21j+/7H5DpxTJ1zEbW4g0i0A LiBK7ljbp9UPsvt+WeFRq3yKjGIlyLzY7Maba3MMJRkgt3dJ9Vn7fM/QA+RrQ5LNudaH C+A5BqwLPCPy+QvkrHOxL3kAZIXft9Mu7YukIENcIKFTSIOvHEhpFI0AxLAOpks2gF7X MrIA== MIME-Version: 1.0 X-Received: by 10.202.95.5 with SMTP id t5mr17661285oib.114.1447643471096; Sun, 15 Nov 2015 19:11:11 -0800 (PST) Received: by 10.182.174.1 with HTTP; Sun, 15 Nov 2015 19:11:11 -0800 (PST) Reply-To: araujo@FreeBSD.org In-Reply-To: <20151116025520.GB2078@Silverstone.nc-us.unovitch.com> References: <201511160224.tAG2OvAo098474@repo.freebsd.org> <20151116025520.GB2078@Silverstone.nc-us.unovitch.com> Date: Mon, 16 Nov 2015 11:11:11 +0800 Message-ID: Subject: Re: svn commit: r401746 - in head/sysutils/pftop: . files From: Marcelo Araujo To: Jason Unovitch Cc: Renato Botelho , ports-committers , "svn-ports-all@freebsd.org" , "svn-ports-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2015 03:11:12 -0000 2015-11-16 10:55 GMT+08:00 Jason Unovitch : > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > On Mon, Nov 16, 2015 at 02:24:57AM +0000, Marcelo Araujo wrote: > > Author: araujo > > Date: Mon Nov 16 02:24:57 2015 > > New Revision: 401746 > > URL: https://svnweb.freebsd.org/changeset/ports/401746 > > > > Log: > > - Add support for ALTQ FairQ and Codel protocols. > > - Bump PORTREVISION to 5. > > > > PR: ports/204405 > > Submitted by: Renato Botelho > > Obtained from: pfSense > > Sponsored by: Rubicon Communications (Netgate) > > > post-patch: > > +.if ${OSVERSION} >= 1100000 > > + @${ECHO_MSG} "===> Applying FairQ/Codel patches to ${PORTNAME}." > > + @${CAT} ${FILESDIR}/extra-patch-fairq_codel.diff | \ > > + ${PATCH} ${PATCH_ARGS} > > +.endif > > @${REINPLACE_CMD} -e 's||"${FILESDIR}/queue.h"|g' \ > > ${WRKSRC}/engine.c > > Is 1100000 wise in this comparision? According to the PHB [1], 1100080 > (r288943) looks to be the minimum safe version as CoDel landed in > r287009 and FairQ landed in r284777. > > [1] > https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/versions.html#freebsd-versions-table > Yes, make sense! Seems not safe use 11000000, but I will wait garga@ reply as he submitted the patch. In my point of view, 1100080 or above is the safest one. Best, -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)