Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 29 Jun 2015 12:09:28 +1000
From:      Kubilay Kocak <koobs@FreeBSD.org>
To:        Mark Felder <feld@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r390797 - head/www/varnish4
Message-ID:  <5590A8D8.7050107@FreeBSD.org>
In-Reply-To: <201506281704.t5SH4M2i019818@svn.freebsd.org>
References:  <201506281704.t5SH4M2i019818@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 29/06/2015 3:04 AM, Mark Felder wrote:
> Author: feld
> Date: Sun Jun 28 17:04:21 2015
> New Revision: 390797
> URL: https://svnweb.freebsd.org/changeset/ports/390797
> 
> Log:
>   Require python as a run dependency, too
>   
>   python is required for you to be able to build custom vmods and also for
>   other vmods in the ports tree to build. Better off including the
>   requirement here as we ship the vmodtool.py utility and do not want to
>   surprise end users.
>   
>   shebangfix was included as the default shebang on vmodtool.py is
>   /usr/bin/env python which is not going to work unless the lang/python
>   metaport is installed, which is not included with USES=python. Instead
>   we just rewrite this to whichever the default system python intepreter
>   is (PYTHON_VERISON).
> 
> Modified:
>   head/www/varnish4/Makefile
> 
> Modified: head/www/varnish4/Makefile
> ==============================================================================
> --- head/www/varnish4/Makefile	Sun Jun 28 16:49:08 2015	(r390796)
> +++ head/www/varnish4/Makefile	Sun Jun 28 17:04:21 2015	(r390797)
> @@ -2,7 +2,7 @@
>  
>  PORTNAME=	varnish
>  PORTVERSION=	4.0.3
> -PORTREVISION=	4
> +PORTREVISION=	5
>  CATEGORIES=	www
>  MASTER_SITES=	http://repo.varnish-cache.org/source/
>  PKGNAMESUFFIX=	4
> @@ -17,7 +17,10 @@ LIB_DEPENDS=	libpcre.so:${PORTSDIR}/deve
>  
>  CONFLICTS=	varnish-2.* varnish-3.*
>  
> -USES=		autoreconf cpe gmake libtool pkgconfig python:build readline
> +USES=		autoreconf cpe gmake libtool pkgconfig python readline shebangfix
> +SHEBANG_FILES=	lib/libvcc/vmodtool.py
> +python_OLD_CMD=	/usr/bin/env python
> +python_CMD=	${LOCALBASE}/bin/${PYTHON_VERSION}
>  CPE_VENDOR=	varnish-cache
>  CFLAGS+=	-I${LOCALBASE}/include
>  GNU_CONFIGURE=	yes
> 

Can this be made optional, say with a TOOLS option or something?

Python is a big RUN_DEPENDS for a .py file that may not be used by default

./koobs



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5590A8D8.7050107>