From owner-cvs-all@FreeBSD.ORG  Wed Jul 15 05:27:23 2009
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4E892106566B
	for <cvs-all@FreeBSD.org>; Wed, 15 Jul 2009 05:27:23 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.freebsd.org (Postfix) with ESMTP id F07E48FC12
	for <cvs-all@FreeBSD.org>; Wed, 15 Jul 2009 05:27:22 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 4698 invoked by uid 399); 15 Jul 2009 05:27:19 -0000
Received: from localhost (HELO foreign.dougb.net)
	(dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTPAM; 15 Jul 2009 05:27:19 -0000
X-Originating-IP: 127.0.0.1
X-Sender: dougb@dougbarton.us
Message-ID: <4A5D68B6.5070702@FreeBSD.org>
Date: Tue, 14 Jul 2009 22:27:18 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 2.0.0.22 (X11/20090625)
MIME-Version: 1.0
To: "Philip M. Gollucci" <pgollucci@FreeBSD.org>
References: <200907150509.n6F59kT1017951@repoman.freebsd.org>
In-Reply-To: <200907150509.n6F59kT1017951@repoman.freebsd.org>
X-Enigmail-Version: 0.95.7
OpenPGP: id=D5B2F0FB
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/sysutils/idled Makefile pkg-plist
 ports/sysutils/idled/files
 idled.in idled.sh patch-Makefile         patch-aa
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2009 05:27:23 -0000

Overall this is a big improvement, thanks. :) The only real error in
the script is the empty _flags assignment which should be removed. You
might also want to take a look at
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html

hope this helps,

Doug


Philip M. Gollucci wrote:
> pgollucci    2009-07-15 05:09:46 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     sysutils/idled       Makefile 
>   Added files:
>     sysutils/idled/files idled.in patch-Makefile 
>   Removed files:
>     sysutils/idled       pkg-plist 
>     sysutils/idled/files idled.sh patch-aa 
>   Log:
>   - USE_RC_SUBR != yes
>   - PLIST_FILES
>   - portlint cleanups
>   
>   Revision  Changes    Path
>   1.14      +4 -14     ports/sysutils/idled/Makefile
>   1.1       +33 -0     ports/sysutils/idled/files/idled.in (new)
>   1.5       +0 -33     ports/sysutils/idled/files/idled.sh (dead)
>   1.1       +104 -0    ports/sysutils/idled/files/patch-Makefile (new)
>   1.5       +0 -105    ports/sysutils/idled/files/patch-aa (dead)
>   1.5       +0 -3      ports/sysutils/idled/pkg-plist (dead)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/idled/Makefile.diff?&r1=1.13&r2=1.14&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/idled/files/idled.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/idled/files/idled.sh
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/idled/files/patch-Makefile
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/idled/files/patch-aa
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/idled/pkg-plist
> 


-- 

    This .signature sanitized for your protection