Date: Tue, 14 Nov 2017 19:24:58 -0700 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r325793 - head/sys/dev/pci Message-ID: <CANCZdfo-%2Bn0JFmwG1Zh3pV-e3pdkOBQhEd8h=RxAGkMvZtkShw@mail.gmail.com> In-Reply-To: <CANCZdfpowWZT-OK=5OW9Dw4hBcaLejU8MnwLnAw9vPhyOVQRyQ@mail.gmail.com> References: <201711140505.vAE555QF042553@repo.freebsd.org> <1911777.0IZEGYVEAQ@ralph.baldwin.cx> <CANCZdfpowWZT-OK=5OW9Dw4hBcaLejU8MnwLnAw9vPhyOVQRyQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 14, 2017 at 10:00 AM, Warner Losh <imp@bsdimp.com> wrote: > > > On Tue, Nov 14, 2017 at 8:47 AM, John Baldwin <jhb@freebsd.org> wrote: > >> On Tuesday, November 14, 2017 05:05:05 AM Warner Losh wrote: >> > Author: imp >> > Date: Tue Nov 14 05:05:05 2017 >> > New Revision: 325793 >> > URL: https://svnweb.freebsd.org/changeset/base/325793 >> > >> > Log: >> > Provide pcie_link_status and pcie_link_cap convenience functions. >> > >> > Sponsored by: Netflix >> >> Note that we already have pcie_read_config() (documented in the manpage). >> With pcie_read_config() these would be one liners: >> >> pcie_link_status() -> pcie_read_config(dev, PCIER_LINK_STA, 2); >> >> This is what the existing hotplug code uses rather than having dedicated >> functions for each PCI-e register. >> >> New functions should be documented in pci.9. >> > > Thanks for the reminders. I'll either transition to the one liner you > talked about, or document the new functions. > Good suggestion. I've implemented this instead in r325838 Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo-%2Bn0JFmwG1Zh3pV-e3pdkOBQhEd8h=RxAGkMvZtkShw>