From owner-svn-src-head@freebsd.org Wed Nov 15 02:25:01 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7D8A0DBCE50 for ; Wed, 15 Nov 2017 02:25:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9A97F7A09A for ; Wed, 15 Nov 2017 02:25:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22c.google.com with SMTP id n134so13762499itg.0 for ; Tue, 14 Nov 2017 18:25:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=kvHzIPVnbzqFZEcsKxuTjJ8PmoQ832270RHDNv5kVYU=; b=I3hJNFJFEcDc8gIKOriU9GKslbgvaBV++XK/4EhGY4pJ0IUCRn8p3geJU+FIHrNhhC TtBtyzOh412plI0J+vRdYH7sJu7DuNjDHkPJXEXLw6bYL2L4wTGoLn9P8m9e29yoCGGm Lt73gQp3bADwhmWKcaSzr00cteExeTIknq89JTFcQRCQyixx8gP9Wev5pcLYF4S5oPfU wynEi3o17ZfR7B0DrTnJnnLUJ4f7qe/kh3wwAWrptnghzipmnY/Z7+2Nu/eZHlQgaEs9 MBajni5zK/aZmnivZzsAVOVXEJxNptSGbRgRcglWdxCh6tXpJQHvNntHhipTZbcbUeGE Tyuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=kvHzIPVnbzqFZEcsKxuTjJ8PmoQ832270RHDNv5kVYU=; b=MNP4XD4vIqbtLhYfGVFD8NmkJMUIxMSGjEY3b4bhqQeuX94dq6Uqtufww++HRSBSQx fFmAYWzKxYgwb7hEPTNWJX/m52ICBLo/xradeWpigfofQHsldXerIU6OoGfUCjW91o/T 30qDRrFnMFzrHuJkLjVt1XyIZc55V+V7IA4VUuKVVTVgF1E0+FY7oPR2tvNxB/uTm7zo LGPXhPJ3oxlnz42Zd9CGWqwPWtsV6UOyrLqCMWfu5l4CZJHpW41VBeQT4YiheRShouHB kaH7J8QCH5TM6AkqLqqDaeR6RtO9BlxLE81pukhbF/7yNtrnpXR4FKwWdXevwBKJNUPM nqng== X-Gm-Message-State: AJaThX4t6PBpLdTzeTnCaI5wyCqFuwVbQqYyq15xUU4ScIobl1BTfsDC Ow+Ro1/BrBlbxN07qo7k9ebL+amPXTSkvGKthCc4FQ== X-Google-Smtp-Source: AGs4zMbJJhco7UGCOqhxqLa0c01C1cdysoEYpNOyrJpsfv0pivZD4+SFd/PCj/W4g+YJvYCfDpRCi/mtoMePdTS+qWw= X-Received: by 10.36.184.5 with SMTP id m5mr18766193ite.69.1510712699446; Tue, 14 Nov 2017 18:24:59 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Tue, 14 Nov 2017 18:24:58 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:9151:cca:5a07:fd20] In-Reply-To: References: <201711140505.vAE555QF042553@repo.freebsd.org> <1911777.0IZEGYVEAQ@ralph.baldwin.cx> From: Warner Losh Date: Tue, 14 Nov 2017 19:24:58 -0700 X-Google-Sender-Auth: eMowI8OCsVgLUzajbJZkfzMywM0 Message-ID: Subject: Re: svn commit: r325793 - head/sys/dev/pci To: John Baldwin Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2017 02:25:01 -0000 On Tue, Nov 14, 2017 at 10:00 AM, Warner Losh wrote: > > > On Tue, Nov 14, 2017 at 8:47 AM, John Baldwin wrote: > >> On Tuesday, November 14, 2017 05:05:05 AM Warner Losh wrote: >> > Author: imp >> > Date: Tue Nov 14 05:05:05 2017 >> > New Revision: 325793 >> > URL: https://svnweb.freebsd.org/changeset/base/325793 >> > >> > Log: >> > Provide pcie_link_status and pcie_link_cap convenience functions. >> > >> > Sponsored by: Netflix >> >> Note that we already have pcie_read_config() (documented in the manpage). >> With pcie_read_config() these would be one liners: >> >> pcie_link_status() -> pcie_read_config(dev, PCIER_LINK_STA, 2); >> >> This is what the existing hotplug code uses rather than having dedicated >> functions for each PCI-e register. >> >> New functions should be documented in pci.9. >> > > Thanks for the reminders. I'll either transition to the one liner you > talked about, or document the new functions. > Good suggestion. I've implemented this instead in r325838 Warner