Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 1 Mar 2015 04:39:08 +0000 (UTC)
From:      Ryan Stone <rstone@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r279474 - stable/10/sys/vm
Message-ID:  <201503010439.t214d8Ju005864@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rstone
Date: Sun Mar  1 04:39:07 2015
New Revision: 279474
URL: https://svnweb.freebsd.org/changeset/base/279474

Log:
  MFC r277649:
  
     vmspace_release() may sleep if the last reference is being released,
     so add a WITNESS_WARN() to catch cases where it is called with a
     non-sleepable lock held.
  
     MFC after:    1 month
     Sponsored by: Sandvine Inc.

Modified:
  stable/10/sys/vm/vm_map.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/vm/vm_map.c
==============================================================================
--- stable/10/sys/vm/vm_map.c	Sun Mar  1 04:36:20 2015	(r279473)
+++ stable/10/sys/vm/vm_map.c	Sun Mar  1 04:39:07 2015	(r279474)
@@ -342,6 +342,9 @@ void
 vmspace_free(struct vmspace *vm)
 {
 
+	WITNESS_WARN(WARN_GIANTOK | WARN_SLEEPOK, NULL,
+	    "vmspace_free() called with non-sleepable lock held");
+
 	if (vm->vm_refcnt == 0)
 		panic("vmspace_free: attempt to free already freed vmspace");
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201503010439.t214d8Ju005864>