Date: Tue, 24 May 2011 21:40:11 GMT From: "joeb1" <joeb1@a1poweruser.com> To: freebsd-ports-bugs@FreeBSD.org Subject: RE: ports/148777: [New Port] sysutils/qjail: Utility to deploy large number of jails quickly Message-ID: <201105242140.p4OLeBMG087099@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/148777; it has been noted by GNATS. From: "joeb1" <joeb1@a1poweruser.com> To: <utisoft@gmail.com>, <joeb@a1poweruser.com> Cc: <bug-followup@freebsd.org> Subject: RE: ports/148777: [New Port] sysutils/qjail: Utility to deploy large number of jails quickly Date: Tue, 24 May 2011 17:30:03 -0400 >> > >I dont know how you came to write the above. > >If you read the last shar post to ports/148777 you will see that all those > >items have been corrected. > >Hands up, I'm sorry, you have corrected _two_ (not all) of the issues >-- the WRKDIR in shar issue. > >You still haven't run portlint, aren't handling config files properly, >nor have you used the correct method of installing a tree of files. > >I've fixed these issues for you, please approve [1]. > >Also, please fix your mailer to not use quoted-printable -- it upsets >GNATS and means I have to cartwheel with sed and tr on your patches. > >Chris > >[1] http://www.bayofrum.net/~crees/patches/qjail.shar > I have run "portlint -A" many times. So if you think I have not then please explain what you are talking about. I think what ever is happening with the attached "shar" file when it is posted to the GNATS reporting system is what is causing the portlint errors you may be seeing. On the subject of the conf file. I don't see what is wrong with the way I handle it. The config is installed as a conf.sample by design. The qjail man page says the user is only to remove the ".sample" suffix from the qjail.conf file if permanently changing the defaults. The qjail.conf file is NOT necessary for qjail to run. So I can not see what you think is wrong with the way I install the conf file. pkg-message has no need for this comment that was added by someone other that me. In order to avoid conflicts with the base /etc/rc.d/jail script it is advised to disable it; # chmod 0000 /etc/rc.d/jail Qjail is designed and tested to function outside of the native jail environment. A mix of native jails which use /etc/rc.d/jail for launching jails has no conflicts with qjail which uses /usr/local/etc/rc.d/qjail2 and qjail-jail2 for launching qjail jails so those comments are not needed and are misleading. Nor have you used the correct method of installing a tree of files. X# note examples are mandatory. qjail will not function without them X @${MKDIR} ${EXAMPLESDIR} X @(cd ${WRKSRC}/examples/ \ X && ${COPYTREE_SHARE} \* ${EXAMPLESDIR}) X I have tested using the your code above and get this make install error "find: */user/local/share/examples/qjail: No such file or directory". Now on the other hand, I get warning messages from "portlint -A" that says "If and only if your port is EXAMPLESDIR-SAFE (that is a user can override EXAMPLESDIR when building this port and the port will still work correctly) consider using the examplesdir macro. " Well since in this ports case it's NOT EXAMPLESDIR-SAFE, because the examples are mandatory, I should NOT use the examplesdir macro because someone may try overriding it creating a un-workable qjail environment. So the way I have it coded is the correct way. ${MKDIR} ${PREFIX}/share/examples/qjail ${CP} -rfp ${WRKSRC}/examples/ ${PREFIX}/share/examples/qjail/ If you have any other items that needs explaining so you will understand what is happening in the qjail make file just email me back with your questions. Joe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201105242140.p4OLeBMG087099>