From owner-cvs-all Thu Dec 9 9: 9:42 1999 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 251CE155AC; Thu, 9 Dec 1999 09:09:40 -0800 (PST) (envelope-from jdp@FreeBSD.org) Received: (from jdp@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id JAA41440; Thu, 9 Dec 1999 09:09:40 -0800 (PST) (envelope-from jdp@FreeBSD.org) Message-Id: <199912091709.JAA41440@freefall.freebsd.org> From: John Polstra Date: Thu, 9 Dec 1999 09:09:39 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/net route.c Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk jdp 1999/12/09 09:09:39 PST Modified files: sys/net route.c Log: Fix a route table leak in rtalloc() and rtalloc_ign(). It is possible for ro->ro_rt to be non-NULL even though the RTF_UP flag is cleared. (Example: a routing daemon or the "route" command deletes a cloned route in active use by a TCP connection.) In that case, the code was clobbering a reference to the routing table entry without decrementing the entry's reference count. The splnet() call probably isn't needed, but I haven't been able to prove that yet. It isn't significant from a performance standpoint since it is executed very rarely. Reviewed by: wollman and others in the freebsd-current mailing list Revision Changes Path 1.57 +13 -6 src/sys/net/route.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message