From owner-freebsd-hackers@freebsd.org Tue Jul 3 13:00:47 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8D0B9101A754 for ; Tue, 3 Jul 2018 13:00:47 +0000 (UTC) (envelope-from munro@penski.net) Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0F5487FD3D for ; Tue, 3 Jul 2018 13:00:46 +0000 (UTC) (envelope-from munro@penski.net) Received: by mail-ed1-x541.google.com with SMTP id g15-v6so1546133edr.12 for ; Tue, 03 Jul 2018 06:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=penski-net.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ySZaMhapXgPyt6byuR/fYxw7sdTr7/vJDFlaxlwNJvQ=; b=ef3kxlSZo2Y04/gHmPTYASUlEYGAu3j6YHDWRjybeMbs//a9NsJPKG6upvPZESibll tgbbiyZcsLKrg/5zXtxSZc144Z0TgjyNsfuVpoGjARcwzx8LzkNcxCXVwl4M+dmMmlyC CyaZCnsSfo6zFZjxgxK4qWwoplmfDw5tDIKP8NVRVMZ2OzXX5oiLCbDgDvO1m7u8d7I6 ERP6gfM3bL455EveiqyhWp+geTobJ3c6MKCpGL2wVxCPVDkHuq6k6M9zkYvspa/jIrDK Ge6E5D4HULhs7+oPL4bBBWVZ6uK0KBhvqmgGuFJ5RXah6cActwmPzWlctKfr/cVOjnU6 HSOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ySZaMhapXgPyt6byuR/fYxw7sdTr7/vJDFlaxlwNJvQ=; b=lNbr2qRD7B+PPZ8dQZokUZF8Fugz1qy2vdjdzl9BLZ+jDsr2mkkYAADECED5GrmIdj kzcz3oYgqwUX3mMFFOQ/LfyFXxf6xZ3iJiTxMGxDE+vm6OmgzxCjoJ/vBBNaekRkrlK0 OJNkPlVKyygItOL9ITSxIKzaoxjd7ezQCMFJJMHJZgg6VO72n/+6nBM7Lpz4lW6QC9mm QaN+s27rmrDHg0XMdcnstasmOTr93rjAzkt0tLZPswQLAaWIEZpmYBb45rHNRK0/Q1lP wbLQhGUkAdnyrmqgIBvPQ7jHO6wot662PefjMtNnQlBC1ns/tgpqv3ogs1t4WosLG77Q CpsQ== X-Gm-Message-State: APt69E0Fx6MuUe4vWquJeMycUTqe2h+CbaPmOwZzhgQO2b7mHZRIWdVo I250Sy5Rd5dZs59vz4QpBDb3icFzkahKqQ05oAxzmQ== X-Google-Smtp-Source: AAOMgpcURbzgsUUWXCpM6KjMsjaekAHdvAQj+PDW/iQJ9AVXzyPF+u74MaL1YvKi5shoDLkxX6+3yqFvBZ+NgAsGfbg= X-Received: by 2002:a50:c2d9:: with SMTP id u25-v6mr29292365edf.56.1530622845767; Tue, 03 Jul 2018 06:00:45 -0700 (PDT) MIME-Version: 1.0 Sender: munro@penski.net Received: by 2002:a50:a1c7:0:0:0:0:0 with HTTP; Tue, 3 Jul 2018 06:00:44 -0700 (PDT) X-Originating-IP: [121.73.38.77] In-Reply-To: <20180702154401.GB2430@kib.kiev.ua> References: <20180702154401.GB2430@kib.kiev.ua> From: Thomas Munro Date: Wed, 4 Jul 2018 01:00:44 +1200 X-Google-Sender-Auth: cNOZ7r2rggtX3-5onsmYzRYwSok Message-ID: Subject: Re: Patching setproctitle() to go faster, for PostgreSQL To: Konstantin Belousov Cc: freebsd-hackers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 13:00:47 -0000 On 3 July 2018 at 03:44, Konstantin Belousov wrote: > The kernel chunk looks fine. > > For the libc, I am not so sure. Why five, why not taking into the > account the frequency, what users could do if they want the old > behaviour e.g. to see the args in vmcore, and so on. Ok. > Is modifying posgresql sources acceptable ? If yes, I propose that you add > setproctitle_fast(3) (I do not insist on the name). Ok, here's a first attempt at that: https://reviews.freebsd.org/D16111 Thanks for the feedback!