Date: Fri, 8 Jul 2011 15:01:14 -0400 From: Ryan Stone <rysto32@gmail.com> To: Peter Wemm <peter@wemm.org> Cc: Kostik Belousov <kostikbel@gmail.com>, Attilio Rao <attilio@freebsd.org>, Sergey Kandaurov <pluknet@freebsd.org>, freebsd-arch@freebsd.org Subject: Re: [PATCH] Add MAXCPU as a kernel config option and quality discussion on this Message-ID: <CAFMmRNxvR_KLfZOy%2BHLktA2W2MxXvvCQ%2Bk1F3zadwFyJicJQxA@mail.gmail.com> In-Reply-To: <CAGE5yCqW97%2BqoF=tXQo53sEx5v30k3Q6ng54LJdK_meP75Uk3Q@mail.gmail.com> References: <CAJ-FndDZu0cBrVbH3W%2B8Tj86T5h%2BwwWqUVnjJO1rtXopKodNOA@mail.gmail.com> <20110708164844.GZ48734@deviant.kiev.zoral.com.ua> <201107081314.44128.jhb@freebsd.org> <CAGE5yCocUvyyNzsMPO8vB4QrBdYEzM=%2BpkPCq8gBHEPu3ypjzA@mail.gmail.com> <CAGE5yCq1B7LZgQOAV2FjNF6kBoGUf_ug7FdpEO3jb%2Berj73CvA@mail.gmail.com> <CAGE5yCqW97%2BqoF=tXQo53sEx5v30k3Q6ng54LJdK_meP75Uk3Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 8, 2011 at 2:22 PM, Peter Wemm <peter@wemm.org> wrote: > Yes, having a default value for sizing cpuset_t does look harmful if a > kld module tries to use them. =A0What is currently in the tree will > silently fail by successfully compiling for kld modules that try to > use anything affected by that. Could we implicitly add something like MODULE_DEPEND(maxcpu, MAXCPU, MAXCPU, MAXCPU); to every kld module so that we reject modules compiled with the wrong MAXCPU value? Maybe add it to DECLARE_MODULE or something.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFMmRNxvR_KLfZOy%2BHLktA2W2MxXvvCQ%2Bk1F3zadwFyJicJQxA>