Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Mar 2000 12:00:20 -0700
From:      Warner Losh <imp@village.org>
To:        Joerg Wunsch <joerg@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/isa fd.c fdc.h 
Message-ID:  <200003181900.MAA97173@harmony.village.org>
In-Reply-To: Your message of "Sat, 18 Mar 2000 10:27:02 PST." <200003181827.KAA70328@freefall.freebsd.org> 
References:  <200003181827.KAA70328@freefall.freebsd.org>  

next in thread | previous in thread | raw e-mail | index | archive | help
In message <200003181827.KAA70328@freefall.freebsd.org> Joerg Wunsch writes:
:   Make the Y-E Data PCMCIA floppy of the Toshiba Libretto work under
:   -current.

And there was much rejoicing :-).  Thank you for your efforts in this
area.  I very much appreciate them.  It is good to see more people
contributing pccard code.

It is likely a good MFC candidate for the newly created 4.0 branch
(but after Jordan does the cdrom thing, since this change appears on
its surface to be large).

:...

excellent commit message, btw

:   WARNING: "fd" is usurping "fd"'s cdevsw[]
:   WARNING: "fd" is usurping "fd"'s bmaj
:   
:   I suspect this is related to the XXX comment at the call to
:   cdevsw_add().  Does anybody know what the correct way is to cleanup
:   this?

The way that the ad driver does this is to use disk_create.  Its use
of disk_destroy causes crashes for me, so I've #if 0'd them out on my
local machines.  You might want to look there.  disk_create does the
cdevsw_add if necessary, but only if necessary.

Warner


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200003181900.MAA97173>