Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 31 Mar 2007 22:38:09 -0700
From:      Colin Percival <cperciva@freebsd.org>
To:        Kris Kennaway <kris@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/amd64/amd64 busdma_machdep.c mem.c mp_watchdog.c pmap.c trap.c src/sys/amd64/conf GENERIC src/sys/amd64/isa isa_dma.c src/sys/arm/arm busdma_machdep.c mem.c pmap.c src/sys/arm/xscale/i80321 i80321_aau.c i80321_dma.c ...
Message-ID:  <460F4541.5060006@freebsd.org>
In-Reply-To: <20070401042209.8F13F51E4D@repoman.freebsd.org>
References:  <20070401042209.8F13F51E4D@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Kris Kennaway wrote:
>   Log:
>   Final stage of SMP pushdown: rename the Giant lock to the Midget lock.
>   ...
>   1.118     +2 -2      src/sys/pci/if_vr.c

This doesn't look quite right:

> --- if_vr.c     23 Feb 2007 12:19:03 -0000      1.117
> +++ if_vr.c     1 Apr 2007 04:21:44 -0000       1.118
> @@ -982,8 +982,8 @@
>                                 printf(" frame alignment error\n");
>                         if (rxstat & VR_RXSTAT_FIFOOFLOW)
>                                 printf(" FIFO overflow");
> -                       if (rxstat & VR_RXSTAT_GIANT)
> -                               printf(" received giant packet");
> +                       if (rxstat & VR_RXSTAT_MIDGET)
> +                               printf(" received midget packet");
>                         if (rxstat & VR_RXSTAT_RUNT)
>                                 printf(" received runt packet");
>                         if (rxstat & VR_RXSTAT_BUSERR)

Colin Percival



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?460F4541.5060006>