Date: Mon, 3 Mar 2003 16:01:33 -0500 (EST) From: Robert Watson <rwatson@FreeBSD.org> To: Nate Lawson <nate@root.org> Cc: Jeff Roberson <jroberson@chesapeake.net>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_default.c Message-ID: <Pine.NEB.3.96L.1030303160011.34673F-100000@fledge.watson.org> In-Reply-To: <Pine.BSF.4.21.0303031227400.78538-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 3 Mar 2003, Nate Lawson wrote: > On Mon, 3 Mar 2003, Jeff Roberson wrote: > > On Mon, 3 Mar 2003, Nate Lawson wrote: > > > Modified files: > > > sys/kern vfs_default.c > > > Log: > > > Pick up one file missed in the previous vprint() cleanup > > > > > Hey, good work here. Do you think there would be any way to use the > > vnode's char name in the generic sync routine? There are a few other > > places where we msleep that could use a more specific name as well. > > Interesting idea but how would you suggest compressing that to 6 chars? > I assume "show lockedvnodes" will always be supreme? And when I just > glanced at the implementation of "show lockedvnodes", I noticed: > mtx_lock(&mountlist_mtx); How can this be correct? It's not. I've been meaning to remove the locking from ddb for ages, and I think Bruce also had patches floating around at one point. BTW, we now get some fascinating failure modes if you do: call boot(0) in ddb, since it runs in an interrupt context using a serial console, and when the shutdown sequence tries to malloc storage, it panics... Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1030303160011.34673F-100000>