From owner-cvs-src@FreeBSD.ORG Thu Dec 6 09:21:28 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D81C116A469; Thu, 6 Dec 2007 09:21:28 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 545B013C467; Thu, 6 Dec 2007 09:21:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8r) with ESMTP id 223005281-1834499 for multiple; Thu, 06 Dec 2007 04:21:34 -0500 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id lB69LL5A014537; Thu, 6 Dec 2007 04:21:22 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Marcel Moolenaar Date: Thu, 6 Dec 2007 04:21:17 -0500 User-Agent: KMail/1.9.6 References: <200712060232.lB62WhFL011174@repoman.freebsd.org> In-Reply-To: <200712060232.lB62WhFL011174@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200712060421.18367.jhb@freebsd.org> Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 06 Dec 2007 04:21:22 -0500 (EST) X-Virus-Scanned: ClamAV 0.91.2/5020/Thu Dec 6 01:21:18 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf NOTES files options src/sys/geom/part g_part.c g_part.h g_part_bsd.c src/sys/ia64/conf DEFAULTS X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Dec 2007 09:21:29 -0000 On Wednesday 05 December 2007 09:32:42 pm Marcel Moolenaar wrote: > marcel 2007-12-06 02:32:42 UTC > > FreeBSD src repository > > Modified files: > sys/conf NOTES files options > sys/geom/part g_part.c g_part.h > sys/ia64/conf DEFAULTS > Added files: > sys/geom/part g_part_bsd.c > Log: > Add a BSD disklabel backend to g_part: > o Disklabels can have between 8 and 20 partitions (inclusive). > o No device special file is created for the raw partition. > o Switch ia64 to use this backend. > o No support for boot code yet. So one issue with gpart is it doesn't handle attribute requests yet, so it doesn't have the feature where geom_bsd only attaches when a parent partition has the right type. I ran into this for GPT testing where due to the way we align disks at work for RAID striping, the beignning of my GPT slice for / had a BSD label at the start, so I would end up with bogus /dev/ad0p1a devices and scary warnings in dmesg about a busted BSD label because offsets didn't match up. I fixed this in 6.x by making GEOM_GPT export its UUID via an attr and having geom_bsd check that like it does now for MBR::type and PC98::type. You will need to handle this in gpart as well. Also, the inability to kldload GPT support is kind of lame now. For my GPT testing with QEMU on my laptop I had to grab GEOM_GPT out of the attic and build its module. -- John Baldwin