From owner-freebsd-net@FreeBSD.ORG Tue Jan 27 00:34:33 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 36CAFAF3 for ; Tue, 27 Jan 2015 00:34:33 +0000 (UTC) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0133.outbound.protection.outlook.com [65.55.169.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B1874AAA for ; Tue, 27 Jan 2015 00:34:32 +0000 (UTC) Received: from CO2PR05MB761.namprd05.prod.outlook.com (10.141.227.13) by CO2PR05MB763.namprd05.prod.outlook.com (10.141.227.15) with Microsoft SMTP Server (TLS) id 15.1.65.19; Tue, 27 Jan 2015 00:00:19 +0000 Received: from CO2PR05MB761.namprd05.prod.outlook.com ([10.141.227.13]) by CO2PR05MB761.namprd05.prod.outlook.com ([10.141.227.13]) with mapi id 15.01.0065.013; Tue, 27 Jan 2015 00:00:19 +0000 From: Sreekanth Rupavatharam To: "freebsd-net@freebsd.org" Subject: Double cleanup in igb_attach Thread-Topic: Double cleanup in igb_attach Thread-Index: AQHQOcQ8M6DG1/D37kKlfeofCj44QA== Date: Tue, 27 Jan 2015 00:00:19 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.4.7.141117 x-originating-ip: [66.129.239.14] authentication-results: freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=juniper.net; x-dmarcaction-test: None x-microsoft-antispam: BCL:0;PCL:0;RULEID:(3005004);SRVR:CO2PR05MB763; x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:;SRVR:CO2PR05MB763; x-forefront-prvs: 046985391D x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(164054003)(92566002)(110136001)(62966003)(2656002)(77156002)(77096005)(40100003)(2900100001)(122556002)(102836002)(66066001)(46102003)(2351001)(107886001)(229853001)(83506001)(106116001)(50986999)(99286002)(36756003)(16236675004)(450100001)(87936001)(86362001)(54356999); DIR:OUT; SFP:1102; SCL:1; SRVR:CO2PR05MB763; H:CO2PR05MB761.namprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; MIME-Version: 1.0 X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2015 00:00:19.1605 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR05MB763 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 00:34:33 -0000 QXBvbG9naWVzIGlmIHRoaXMgaXMgbm90IHRoZSByaWdodCBmb3J1bS4gSW4gaWdiX2F0dGFjaCBm dW5jdGlvbiwgd2UgaGF2ZSB0aGlzIGNvZGUuDQplcnJfbGF0ZToNCmlnYl9kZXRhY2goZGV2KTsN CiAgICAgICAgaWdiX2ZyZWVfdHJhbnNtaXRfc3RydWN0dXJlcyhhZGFwdGVyKTsNCiAgICAgICAg aWdiX2ZyZWVfcmVjZWl2ZV9zdHJ1Y3R1cmVzKGFkYXB0ZXIpOw0KICAgICAgICBpZ2JfcmVsZWFz ZV9od19jb250cm9sKGFkYXB0ZXIpOw0KZXJyX3BjaToNCiAgICAgICAgaWdiX2ZyZWVfcGNpX3Jl c291cmNlcyhhZGFwdGVyKTsNCiAgICAgICAgaWYgKGFkYXB0ZXItPmlmcCAhPSBOVUxMKQ0KICAg ICAgICAgICAgICAgIGlmX2ZyZWUoYWRhcHRlci0+aWZwKTsNCiAgICAgICAgZnJlZShhZGFwdGVy LT5tdGEsIE1fREVWQlVGKTsNCiAgICAgICAgSUdCX0NPUkVfTE9DS19ERVNUUk9ZKGFkYXB0ZXIp Ow0KDQpUaGUgcHJvYmxlbSBpcyB0aGF0IGlnYl9kZXRhY2ggYWxzbyBkb2VzIHRoZSBzYW1lIGNs ZWFudXAgaW4gaXTigJlzIGJvZHkuIE9ubHkgZXhjZXB0aW9uIGlzIHRoaXMgY2FzZSB3aGVyZSBp dCBqdXN0IHJldHVybnMgRUJVU1kNCiAgICAgICAgLyogTWFrZSBzdXJlIFZMQU5TIGFyZSBub3Qg dXNpbmcgZHJpdmVyICovDQppZiAoaWZfdmxhbnRydW5raW51c2UoaWZwKSkgew0KZGV2aWNlX3By aW50ZihkZXYsIlZsYW4gaW4gdXNlLCBkZXRhY2ggZmlyc3RcbiIpOw0KcmV0dXJuIChFQlVTWSk7 DQp9DQoNCkkgdGhpbmsgdGhlIGNvZGUgaW4gaWdiX2F0dGFjaCBzaG91bGQgYmUgY2hhbmdlZCB0 byBmcmVlIHVwIHJlc291cmNlcyBvbmx5IGlmIHRoZSBpZ2JfZGV0YWNoIHJldHVybnMgYW4gZXJy b3IuIEhlcmXigJlzIHRoZSBwYXRjaCBmb3IgaXQuDQoNCg0KSW5kZXg6IGlmX2lnYi5jDQoNCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0NCg0KLS0tIGlmX2lnYi5jIChyZXZpc2lvbiAyOTgwMjUpDQoNCisrKyBpZl9pZ2Iu YyAod29ya2luZyBjb3B5KQ0KDQpAQCAtNzIzLDcgKzcyMyw4IEBAIGlnYl9hdHRhY2goZGV2aWNl X3QgZGV2KQ0KDQogIHJldHVybiAoMCk7DQoNCg0KDQogZXJyX2xhdGU6DQoNCi0gaWdiX2RldGFj aChkZXYpOw0KDQorIGlmKGlnYl9kZXRhY2goZGV2KSA9PSAwKSAvKiBpZ2JfZGV0YWNoIGRpZCB0 aGUgY2xlYW51cCAqLw0KDQorIHJldHVybjsNCg0KICBpZ2JfZnJlZV90cmFuc21pdF9zdHJ1Y3R1 cmVzKGFkYXB0ZXIpOw0KDQogQ2FuIGFueW9uZSBjb21tZW50IG9uIGl0IGFuZCB0ZWxsIG1lIGlm IG15IHVuZGVyc3RhbmRpbmcgaXMgaW5jb3JyZWN0Pw0KDQotLSBUaGFua3MsDQoNClNyZWVrYW50 aA0KDQoNCg==