From owner-svn-src-all@FreeBSD.ORG Tue Jan 29 21:44:23 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 0BC65DF0; Tue, 29 Jan 2013 21:44:23 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id F27ED95F; Tue, 29 Jan 2013 21:44:22 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id r0TLiM5c064277; Tue, 29 Jan 2013 21:44:22 GMT (envelope-from glebius@svn.freebsd.org) Received: (from glebius@localhost) by svn.freebsd.org (8.14.5/8.14.5/Submit) id r0TLiMYs064276; Tue, 29 Jan 2013 21:44:22 GMT (envelope-from glebius@svn.freebsd.org) Message-Id: <201301292144.r0TLiMYs064276@svn.freebsd.org> From: Gleb Smirnoff Date: Tue, 29 Jan 2013 21:44:22 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r246095 - head/sys/net X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2013 21:44:23 -0000 Author: glebius Date: Tue Jan 29 21:44:22 2013 New Revision: 246095 URL: http://svnweb.freebsd.org/changeset/base/246095 Log: route_output() always supplies info with RTAX_GATEWAY member that points to a sockaddr of AF_LINK family. Assert this instead of checking. Modified: head/sys/net/if_llatbl.c Modified: head/sys/net/if_llatbl.c ============================================================================== --- head/sys/net/if_llatbl.c Tue Jan 29 21:37:56 2013 (r246094) +++ head/sys/net/if_llatbl.c Tue Jan 29 21:44:22 2013 (r246095) @@ -273,10 +273,9 @@ lla_rt_output(struct rt_msghdr *rtm, str u_int laflags = 0, flags = 0; int error = 0; - if (dl == NULL || dl->sdl_family != AF_LINK) { - log(LOG_INFO, "%s: invalid dl\n", __func__); - return EINVAL; - } + KASSERT(dl != NULL && dl->sdl_family == AF_LINK, + ("%s: invalid dl\n", __func__)); + ifp = ifnet_byindex(dl->sdl_index); if (ifp == NULL) { log(LOG_INFO, "%s: invalid ifp (sdl_index %d)\n",