From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Nov 12 12:10:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C9B34565 for ; Tue, 12 Nov 2013 12:10:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A71AF26B3 for ; Tue, 12 Nov 2013 12:10:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rACCA0mW011415 for ; Tue, 12 Nov 2013 12:10:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rACCA0wa011414; Tue, 12 Nov 2013 12:10:00 GMT (envelope-from gnats) Resent-Date: Tue, 12 Nov 2013 12:10:00 GMT Resent-Message-Id: <201311121210.rACCA0wa011414@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mathieu Arnold Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AE57754E for ; Tue, 12 Nov 2013 12:09:32 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 74DAA26A4 for ; Tue, 12 Nov 2013 12:09:29 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 3BA8BBDC5D for ; Tue, 12 Nov 2013 13:09:28 +0100 (CET) Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "gw.in.absolight.net", Issuer "CA Cert Signing Authority" (not verified)) by prod2.absolight.net (Postfix) with ESMTPSA id 140B8BDC44 for ; Tue, 12 Nov 2013 13:09:28 +0100 (CET) Received: from aragorn.in.absolight.net (aragorn.in.absolight.net [79.143.241.225]) by gw.in.absolight.net (Postfix) with ESMTP id 183C76145 for ; Tue, 12 Nov 2013 13:09:27 +0100 (CET) Received: by aragorn.in.absolight.net (Postfix, from userid 1000) id 0A8DA14269C; Tue, 12 Nov 2013 13:09:25 +0100 (CET) Message-Id: <20131112120926.0A8DA14269C@aragorn.in.absolight.net> Date: Tue, 12 Nov 2013 13:09:25 +0100 (CET) From: Mathieu Arnold To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.114 Subject: ports/183892: Allow multiple value in ${opt}_USE= FOO=bar,baz X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list Reply-To: Mathieu Arnold List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Nov 2013 12:10:01 -0000 >Number: 183892 >Category: ports >Synopsis: Allow multiple value in ${opt}_USE= FOO=bar,baz >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Nov 12 12:10:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Mathieu Arnold >Release: FreeBSD 9.2-RELEASE i386 >Organization: Absolight >Environment: System: FreeBSD aragorn.in.absolight.net 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255898: Fri Sep 27 03:52:52 UTC 2013 root@bake.isc.freebsd.org:/usr/obj/usr/src/sys/GENERIC i386 >Description: When you had : .if !defined(WITHOUT_X11) USE_XORG= x11 ice sm xext xineramaproto xinerama xrandr xrender xtst .endif you need to do now X11_USE= xorg=x11 xorg=ice xorg=sm xorg=xext xorg=xineramaproto xorg=xinerama xorg=xrandr xorg=xrender xorg=xtst which is ugly. With this patch you can do : X11_USE= xorg=x11,ice,sm,xext,xineramaproto,xinerama,xrandr,xrender,xtst >How-To-Repeat: >Fix: --- use_mk_multiple.diff begins here --- Index: Mk/bsd.options.mk =================================================================== --- Mk/bsd.options.mk (revision 333559) +++ Mk/bsd.options.mk (working copy) @@ -95,6 +95,8 @@ # # ${opt}_USE= FOO=bar When option is enabled, it will enable # USE_FOO+= bar +# If you need more than one option, you can do +# FOO=bar,baz and you'll get USE_FOO=bar baz # # For each of CFLAGS CPPFLAGS CXXFLAGS LDFLAGS CONFIGURE_ENV MAKE_ARGS MAKE_ENV # ALL_TARGET INSTALL_TARGET USES DISTFILES PLIST_FILES PLIST_DIRS PLIST_DIRSTRY @@ -383,7 +385,7 @@ . if defined(${opt}_USE) . for option in ${${opt}_USE} _u= ${option:C/=.*//g} -USE_${_u:U}+= ${option:C/.*=//g} +USE_${_u:U}+= ${option:C/.*=//g:C/,/ /g} . endfor . endif . if defined(${opt}_CONFIGURE_ENABLE) --- use_mk_multiple.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: