Date: Wed, 24 Jan 2001 00:06:17 -0800 From: Jeremy Lea <reg@FreeBSD.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/add extract.c main.c src/usr.sbin/pkg_install/create create.h main.c perform.c pkg_create.1 src/usr.sbin/pkg_install/lib file.c plist.c Message-ID: <20010124000617.C63549@shale.csir.co.za> In-Reply-To: <200101221201.f0MC1tV27540@freefall.freebsd.org>; from sobomax@FreeBSD.org on Mon, Jan 22, 2001 at 04:01:55AM -0800 References: <200101221201.f0MC1tV27540@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
On Mon, Jan 22, 2001 at 04:01:55AM -0800, Maxim Sobolev wrote:
> Modified files:
> usr.sbin/pkg_install/add extract.c main.c
> usr.sbin/pkg_install/create create.h main.c perform.c
> pkg_create.1
> usr.sbin/pkg_install/lib file.c plist.c
> Log:
> - Add ability to handle bzip2-compressed packages;
The code in create/main.c never turns UseBzip2 = TRUE. Which implies
it was never tested, which also implies that the command line switch is
redundant. We can guess bzip2 compression from the suffix. In fact we
have to have a bzip2 suffix, else we can't guess how to extract it, so
having a command line switch can only cause bad things to happen.
> No response from: -ports
This should have read
Approved by: jkh
He is the maintainer of this code, not -ports. (Even if he never
changes it or reviews patches :-( )
Regards,
-Jeremy
--
FreeBSD - Because the best things in life are free...
http://www.freebsd.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010124000617.C63549>