From owner-svn-src-all@FreeBSD.ORG Tue Nov 11 16:06:34 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4DDBFCF for ; Tue, 11 Nov 2014 16:06:34 +0000 (UTC) Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com [209.85.217.176]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E202CF74 for ; Tue, 11 Nov 2014 16:06:33 +0000 (UTC) Received: by mail-lb0-f176.google.com with SMTP id 10so7730152lbg.21 for ; Tue, 11 Nov 2014 08:06:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=DU72SveHGJoIAz4uwDaZhBMeXmm8zTh+fc2Uk7HNqdo=; b=YirKDnGs/WGpzA9+RByUp5LmLiia3rB7oORiUt3dKQdJioxrbJYoIB87jcJ9IDb/6d W+dti2IWXe4TRwvAD4qQNdAZKhHQxCHccFxNgxFhzoVa/crbikoeVBUwgnmmxNC2w39E lDWYENpHJp6Uzrl/vViy1UgsZUHS7wtuBjsGGshwmKNEWBRBAVpDk6eHdyd5dfewPyyQ rn/K4GrITPtXy1xyGWAS7f0fV04TmeoW1NEgccYoj1IMC7KuZ3rOtp950E+/sGmFcLbn 4fVUNtiQyJVwpkwCTE395zdlOkbZmt9ceJd7NV1QGaGw2i7qQ8I4QwEn9duXbO2vT8Lq MdAw== X-Gm-Message-State: ALoCoQmWCYWmN4E9MPFyFaGoEyblt0xJH68XK7voq1EyZyStbMDwDKv4VmLk+bA6BjurwrvjYLA3 X-Received: by 10.112.11.133 with SMTP id q5mr16229164lbb.77.1415721985573; Tue, 11 Nov 2014 08:06:25 -0800 (PST) Received: from [192.168.1.2] ([89.169.173.68]) by mx.google.com with ESMTPSA id j6sm6077820lbs.9.2014.11.11.08.06.24 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Nov 2014 08:06:24 -0800 (PST) Message-ID: <54623400.1080407@freebsd.org> Date: Tue, 11 Nov 2014 19:06:24 +0300 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Garrett Cooper Subject: Re: svn commit: r274365 - head/contrib/tzcode/stdtime References: <201411110407.sAB47gBT003976@svn.freebsd.org> <54621043.9000502@freebsd.org> <920BE50C-2DBA-4DCE-BFAB-ACFC11C5A09E@gmail.com> In-Reply-To: <920BE50C-2DBA-4DCE-BFAB-ACFC11C5A09E@gmail.com> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Garrett Cooper X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Nov 2014 16:06:34 -0000 On 11.11.2014 18:34, Garrett Cooper wrote: >> This code is wrong in any case, setting EOVERFLOW even in unneeded >> no-error cases like breaking from the loop. See how NetBSD does it >> correctly instead. > > Hi! > I saw your reply earlier but hadn't gotten an opportunity to revise the patch like you suggested. I'll look at the NetBSD code and see if I can adapt it to our copy of tzcode. > Thank you! > Currently as we need only EOVERFLOW parts from it, I don't think it will be hard task to merge only them. -- http://ache.vniz.net/