Date: Tue, 10 Mar 2015 13:33:29 -0600 From: Scott Long <scott4long@yahoo.com> To: Ian Lepore <ian@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r279828 - head/sys/dev/cadence Message-ID: <9F60FF00-B6B4-4197-993A-9848F1C3A923@yahoo.com> In-Reply-To: <201503092239.t29MdxUo089384@svn.freebsd.org> References: <201503092239.t29MdxUo089384@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Mar 9, 2015, at 4:39 PM, Ian Lepore <ian@FreeBSD.org> wrote: >=20 > Author: ian > Date: Mon Mar 9 22:39:58 2015 > New Revision: 279828 > URL: https://svnweb.freebsd.org/changeset/base/279828 >=20 > Log: > Use the new ifnet API. Also, allocate bus_dma_maps as needed instead = of > pre-allocating them all at start-up. Also fix a bug in cgem_stop(); = before, > it wasn't properly unloading dma maps due to a cut-and-paste error. >=20 It=E2=80=99s generally a very bad idea to create and destroy maps for = every transaction. If the map results in being non-NULL, then you=E2=80=99re allocating and freeing = memory on every transaction, and possibly allocating and freeing large chunks of memory for bounce = buffers. Is there a reason why you=E2=80=99ve made this change? Thanks, Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9F60FF00-B6B4-4197-993A-9848F1C3A923>