Date: Thu, 17 Feb 2005 12:51:37 -0700 (MST) From: Warner Losh <imp@bsdimp.com> To: maxim@macomnet.ru Cc: sos@DeepCore.dk Subject: Re: UPDATE2: ATA mkIII first official patches - please test! Message-ID: <20050217.125137.74752166.imp@bsdimp.com> In-Reply-To: <20050217212655.E14434@mp2.macomnet.net> References: <420A1792.900@DeepCore.dk> <421464C3.2030308@DeepCore.dk> <20050217212655.E14434@mp2.macomnet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> atadisk.ko and atapicd.ko still do not depend on atapci.ko. So if you > don't ask to load atapci.ko in loader.conf you will get a panic > because the kernel won't find the root fs. I added MODULE_DEPEND() on > atapci macro to ata-disk.c and this solved the problem. Perhaps this > is just a feature. MODULE_DEPEND should only be there when when there's a link time dependency between modles. If you were to add the atapci.ko as a depend, then you destroy the ability to boot on machines that don't have a pci bus in the kernel.... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050217.125137.74752166.imp>