From owner-cvs-all@FreeBSD.ORG Sun Aug 22 04:10:28 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CF85816A4D1; Sun, 22 Aug 2004 04:10:25 +0000 (GMT) Received: from green.homeunix.org (pcp04371970pcs.nrockv01.md.comcast.net [69.140.223.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD10D43D48; Sun, 22 Aug 2004 04:10:24 +0000 (GMT) (envelope-from green@green.homeunix.org) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i7M4AIIk000995; Sun, 22 Aug 2004 00:10:18 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i7M4AIDI000994; Sun, 22 Aug 2004 00:10:18 -0400 (EDT) (envelope-from green) Date: Sun, 22 Aug 2004 00:10:18 -0400 From: Brian Fundakowski Feldman To: Robert Watson Message-ID: <20040822041018.GA937@green.homeunix.org> References: <20040822015800.GE784@green.homeunix.org> <20040822033955.GA3629@green.homeunix.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040822033955.GA3629@green.homeunix.org> User-Agent: Mutt/1.5.6i cc: Alan Cox cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Alan Cox cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_fault.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Aug 2004 04:10:28 -0000 On Sat, Aug 21, 2004 at 11:39:55PM -0400, Brian Fundakowski Feldman wrote: > On Sat, Aug 21, 2004 at 10:30:03PM -0400, Robert Watson wrote: > > > > On Sat, 21 Aug 2004, Brian Fundakowski Feldman wrote: > > > > > > > #1. Lock order reversal. Giant is acquired after the map read lock. > > > > > > > > No, that is the order it has been in for months. The other functions > > > > that acquire a map lock and Giant do the same. > > > > > > Giant can never be acquired after another lock has been acquired :-( > > > > Actually, that's not quite accurate. Take a look at the relationship > > between lockmgr/sx locks and Giant, for example. > > Point taken. This is the first time I've seen Giant in a lock order > reversal with vm locks, though, and I've been running WITNESS for years. Also, it was the system_map lock, so it was a mutex, not an sx. /Goes back to trying to figure out wtf portupgrade -rR kde\* keeps causing hangs, but only in X, not at the command line, and not seemingly dependant on AGP/X driver. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\