Date: Tue, 8 Sep 2009 13:20:00 -0300 From: Renato Botelho <garga@FreeBSD.org> To: Nikos Ntarmos <ntarmos@cs.uoi.gr> Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/138183: [PATCH] x11/xcb-util: update to 0.3.6 Message-ID: <20090908162000.GA9355@bluepex.com> In-Reply-To: <200909050810.n858A37o054971@freefall.freebsd.org> References: <200909050810.n858A37o054971@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Sep 05, 2009 at 08:10:03AM +0000, Nikos Ntarmos wrote: > The following reply was made to PR ports/138183; it has been noted by GNATS. > > Since x11/xcb-util v0.3.5 I've received multiple emails about xcb-util > failing to build. This is caused by x11/libxcb having been built against > x11/xcb-proto version 1.4, while xcb-util requires the former to be > built against xcb-proto 1.5 or higher. As of this, I've added a check in > xcb-util's Makefile to warn when this is the case. Obviously, this > situation arises when the installed ports are not fully in sync with the > ports tree or when libxcb has been installed via an early package. If > the added check is deemed unnecessary, then the patch supplied by Renato > is good to go, but perhaps we should add a line or two in UPDATING. What do you think about add xcb-proto dependency explicit on BUILD_DEPENDS set with a version check, like following patch: Index: Makefile =================================================================== RCS file: /home/pcvs/ports/x11/xcb-util/Makefile,v retrieving revision 1.12 diff -u -r1.12 Makefile --- Makefile 2 Aug 2009 19:36:11 -0000 1.12 +++ Makefile 8 Sep 2009 16:16:42 -0000 @@ -6,7 +6,7 @@ # PORTNAME= xcb-util -PORTVERSION= 0.3.5 +PORTVERSION= 0.3.6 CATEGORIES= x11 MASTER_SITES= http://xcb.freedesktop.org/dist/ @@ -14,7 +14,8 @@ COMMENT= A module with libxcb/libX11 extension/replacement libraries LIB_DEPENDS= xcb.2:${PORTSDIR}/x11/libxcb -BUILD_DEPENDS= ${LOCALBASE}/bin/gperf:${PORTSDIR}/devel/gperf +BUILD_DEPENDS= ${LOCALBASE}/bin/gperf:${PORTSDIR}/devel/gperf \ + xcb-proto>=1.5:${PORTSDIR}/x11/xcb-proto USE_BZIP2= yes USE_GMAKE= yes Index: distinfo =================================================================== RCS file: /home/pcvs/ports/x11/xcb-util/distinfo,v retrieving revision 1.7 diff -u -r1.7 distinfo --- distinfo 16 Jun 2009 18:03:00 -0000 1.7 +++ distinfo 8 Sep 2009 16:16:42 -0000 @@ -1,3 +1,3 @@ -MD5 (xcb-util-0.3.5.tar.bz2) = 13649baa059dcea7779d2b9ff3843888 -SHA256 (xcb-util-0.3.5.tar.bz2) = 484097ce4a847894d239ee505c8db1249950ef8b4be6dc1fdd1929de2d4e0f25 -SIZE (xcb-util-0.3.5.tar.bz2) = 262991 +MD5 (xcb-util-0.3.6.tar.bz2) = dd8968b8ee613cb027a8ef1fcbdc8fc9 +SHA256 (xcb-util-0.3.6.tar.bz2) = ffb8ee11ab015858a970ab7edd56bd2436b281657596561d8429d4a90df60e57 +SIZE (xcb-util-0.3.6.tar.bz2) = 293408 What do you think? -- Renato Botelho <garga @ FreeBSD.org> <garga @ freebsdbrasil.com.br> GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc Syntactic sugar causes cancer of the semicolon. -- Epigrams in Programming, ACM SIGPLAN Sept. 1982
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090908162000.GA9355>