From owner-cvs-all@FreeBSD.ORG Tue Sep 18 21:42:00 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D03F16A417; Tue, 18 Sep 2007 21:42:00 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id EDD5913C45D; Tue, 18 Sep 2007 21:41:59 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l8ILfu19006443; Tue, 18 Sep 2007 15:41:56 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <46F04620.3090500@samsco.org> Date: Tue, 18 Sep 2007 15:41:52 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: "Bruce A. Mah" References: <200709180420.l8I4KMFG057365@repoman.freebsd.org> <20070918145953.GW79542@deviant.kiev.zoral.com.ua> <46F02B62.8080504@samsco.org> <46F03493.7050808@freebsd.org> In-Reply-To: <46F03493.7050808@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Tue, 18 Sep 2007 15:41:57 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: Kostik Belousov , cvs-src@freebsd.org, Tim Kientzle , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libarchive archive_write_disk.c src/lib/libarchive/test test_write_disk.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2007 21:42:00 -0000 Bruce A. Mah wrote: > If memory serves me right, Scott Long wrote: >> Kostik Belousov wrote: >>> On Tue, Sep 18, 2007 at 04:20:21AM +0000, Tim Kientzle wrote: >>>> kientzle 2007-09-18 04:20:21 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> lib/libarchive archive_write_disk.c >>>> lib/libarchive/test test_write_disk.c >>>> Log: >>>> Correct the return value from archive_write_data() >>>> (when used to restore files to disk) to match: >>>> * The documentation >>>> * The return values of this function when used >>>> to write files into an archive. >>>> >>>> Approved by: re (bmah) >>>> Pointy hat: \me >>>> MFC after: 5 days >>>> >>>> Revision Changes Path >>>> 1.15 +7 -4 src/lib/libarchive/archive_write_disk.c >>>> 1.4 +26 -1 src/lib/libarchive/test/test_write_disk.c > > [snip] > >>> Stop in /usr/ports/audio/sdl_mixer. >>> *** Error code 1 >>> >>> It seems that tar is broken. >> I think this patch needs to be backed out until further review is >> obtained. This isn't a good time to leave things in a broken state for >> a week while we try to figure out the "right" thing to do. Just back it >> out to a known good state, then discuss and argue at your leisure. > > With my RE hat on, I've backed out this commit. > > Bruce. > > Thanks a lot Bruce! Scott