From owner-svn-src-all@FreeBSD.ORG Wed May 8 18:21:13 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 907AD29A; Wed, 8 May 2013 18:21:13 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-ia0-x232.google.com (mail-ia0-x232.google.com [IPv6:2607:f8b0:4001:c02::232]) by mx1.freebsd.org (Postfix) with ESMTP id 49B08343; Wed, 8 May 2013 18:21:13 +0000 (UTC) Received: by mail-ia0-f178.google.com with SMTP id t29so2212597iag.23 for ; Wed, 08 May 2013 11:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=ULB8ZMHFILCJ0+o2ceWI1dnnJGLthl7P1gtuv0hOlFY=; b=CFIMUhTspOFql23klcKmLZEw8f3d86SO9efV5dfg+qDroaGf7kwTwkV3smBx5X6H7S nusDMsgglpQuX3+DQ7Bd8idkCfgoC1bBZihFEITrawzprE3vIhWYxSXjVvOlSk45vc9w Nu/VPDzAXlklqSWHIE/E04sI4NJHSnO8QZaeKgD/qwo6qtX2S4hL3MolWc5oeso5Avl7 eBWZ5HHsXfKIXj4q5rfUD75rXPVxYwydwE+sCcfIlplRJ6sDMF21jvnCFsQoL3Y2JqtX rQrElYWn+qEty+aJfw0L/OgiOqO56PLOl5Myb+qenbDY7vWcg7WYRipNUMZmIVoGJOZN 9BIw== MIME-Version: 1.0 X-Received: by 10.50.7.36 with SMTP id g4mr3019798iga.64.1368037273042; Wed, 08 May 2013 11:21:13 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.42.117.134 with HTTP; Wed, 8 May 2013 11:21:12 -0700 (PDT) In-Reply-To: <201305081201.16405.jhb@freebsd.org> References: <201305072249.r47MnvrO009846@svn.freebsd.org> <201305081201.16405.jhb@freebsd.org> Date: Wed, 8 May 2013 20:21:12 +0200 X-Google-Sender-Auth: Aj3R6Q386rXpHzOyr9FPnywGIkw Message-ID: Subject: Re: svn commit: r250339 - head/sys/x86/acpica From: Attilio Rao To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 May 2013 18:21:13 -0000 On Wed, May 8, 2013 at 6:01 PM, John Baldwin wrote: > On Tuesday, May 07, 2013 6:49:57 pm Attilio Rao wrote: >> Author: attilio >> Date: Tue May 7 22:49:56 2013 >> New Revision: 250339 >> URL: http://svnweb.freebsd.org/changeset/base/250339 >> >> Log: >> Add functions to do ACPI System Locality Information Table parsing >> and printing at boot. >> For reference on table informations and purposes please review ACPI specs. >> >> Sponsored by: EMC / Isilon storage division >> Obtained from: jeff >> Reviewed by: jhb (earlier version) > > Eh, I don't recall reviewing this. However, acpidump already dumps this > table, and we should dump tables via acpidump, not in dmesg. Now that I read better this patch is based upon a patch you submitted originally (see the private thread NUMA WIP). We already print some useful ACPI table information at boot really (APIC ACPI table case) and this is only printed out when having MAXMEMDOM > 1. Finally I have also sent you this patch and you didn't object. However if you really dislike it I can print under bootverbose maybe? Attilio -- Peace can only be achieved by understanding - A. Einstein