Date: Tue, 26 Nov 2013 12:34:09 -0000 From: "Steven Hartland" <killing@multiplay.co.uk> To: "Andriy Gapon" <avg@FreeBSD.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: Re: svn commit: r258632 - in head: cddl/contrib/opensolaris/cmd/ztest cddl/contrib/opensolaris/lib/libzpool/common/sys sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys... Message-ID: <AEC0945BC2474F7A835A8F4AFB988F0F@multiplay.co.uk> References: <201311260957.rAQ9vF6d004168@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Can I ask why choose priority now for TRIM, does this not change the flow of
free requests quite significantly?
Also as we have rotational information available should we apply
the following change which makes the active queue timestamp sorted
instead of offset sorted?
An AVL as a FIFO queue seems like quite an expensive option.
Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_queue.c
===================================================================
--- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_queue.c (revision 258644)
+++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_queue.c (working copy)
@@ -262,7 +263,9 @@
mutex_init(&vq->vq_lock, NULL, MUTEX_DEFAULT, NULL);
vq->vq_vdev = vd;
- avl_create(&vq->vq_active_tree, vdev_queue_offset_compare,
+ avl_create(&vq->vq_active_tree,
+ vd->vdev_rotation_rate == VDEV_RATE_NON_ROTATING ?
+ vdev_queue_timestamp_compare : vdev_queue_offset_compare,
sizeof (zio_t), offsetof(struct zio, io_queue_node));
----- Original Message -----
From: "Andriy Gapon" <avg@FreeBSD.org>
To: <src-committers@freebsd.org>; <svn-src-all@freebsd.org>; <svn-src-head@freebsd.org>
Sent: Tuesday, November 26, 2013 9:57 AM
Subject: svn commit: r258632 - in head: cddl/contrib/opensolaris/cmd/ztest cddl/contrib/opensolaris/lib/libzpool/common/sys
sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys...
> Author: avg
> Date: Tue Nov 26 09:57:14 2013
> New Revision: 258632
> URL: http://svnweb.freebsd.org/changeset/base/258632
>
> Log:
> MFV r255255: 4045 zfs write throttle & i/o scheduler performance work
>
> illumos/illumos-gate@69962b5647e4a8b9b14998733b765925381b727e
>
> Please note the following changes:
> - zio_ioctl has lost its priority parameter and now TRIM is executed
> with 'now' priority
> - some knobs are gone and some new knobs are added; not all of them are
> exposed as tunables / sysctls yet
...
================================================
This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it.
In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337
or return the E.mail to postmaster@multiplay.co.uk.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AEC0945BC2474F7A835A8F4AFB988F0F>