Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Jun 2012 06:01:48 -0500
From:      Jan Beich <jbeich@tormail.org>
To:        Dimitry Andric <dim@FreeBSD.org>
Cc:        freebsd-current <freebsd-current@freebsd.org>
Subject:   Re: [CFC/CFT] large changes in the loader(8) code
Message-ID:  <1SkYxx-0007Fr-SA@internal.tormail.org>
In-Reply-To: <4FEB5B0E.8020009@FreeBSD.org> (Dimitry Andric's message of "Wed,  27 Jun 2012 21:12:14 %2B0200")
References:  <4FE9B01C.30306@yandex.ru> <4FEB5B0E.8020009@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Dimitry Andric <dim@FreeBSD.org> writes:

> On 2012-06-26 14:50, Andrey V. Elsukov wrote:
>
>> Some time ago i have started reading the code in the sys/boot.
>> Especially i'm interested in the partition tables handling.
>> I found several problems:
>> 1. There are several copies of the same code in the libi386/biosdisk.c
>> and common/disk.c, and partially libpc98/biosdisk.c.
>> 2. ZFS probing is very slow, because the ZFS code doesn't know how many
>> disks and partitions the system has:
>> 	http://www.freebsd.org/cgi/query-pr.cgi?pr=148296
>> 	http://www.freebsd.org/cgi/query-pr.cgi?pr=161897
>> 3. The GPT support doesn't check CRC and even doesn't know anything
>> about the secondary GPT header/table.
>> 
>> So, i have created the branch and committed the changes:
>> 	http://svnweb.freebsd.org/base/user/ae/bootcode/
>> The patch is here:
>> 	http://people.freebsd.org/~ae/boot.diff
>
> FWIW, I verified it compiles OK with clang, and especially boot2's size
> isn't increased at all.

Does it boot for you? Same if I build zfs.c with gcc -O0:

  FreeBSD/x86 ZFS enabled bootstrap loader, Revision 1.1
  (foo@bar, Tue Jun 26 18:52:52 UTC 2012)
  ZFS: can't find pool by guid
  ZFS: can't find pool by guid

  can't load 'kernel'

>
> It would be nice if you could check it with clang now and again, before
> you finally merge this project into head.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1SkYxx-0007Fr-SA>