Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Jan 2003 14:05:54 -0600
From:      "Alan L. Cox" <alc@imimic.com>
To:        Matthew Dillon <dillon@apollo.backplane.com>
Cc:        scsi@freebsd.org, gibbs@freebsd.org, Tor.Egge@cvsup.no.freebsd.org
Subject:   Re: vmapbuf() changes effect CAM (patch)
Message-ID:  <3E2710A2.97A2BB07@imimic.com>
References:  <200301160225.h0G2PE21019224@apollo.backplane.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Dillon wrote:
> ...
>     Alan, Tor, if you could review the whole patch I would appreciate it.
>     Note that this is an incremental patch, it fixes the vmapbuf() race but
>     does not yet clean up the useracc() checks (to just check that the
>     address range is within the user VM space rather then also checking
>     the map entries).
> 

You must hold the page queues lock around vm_page_unhold().  You might
as well add similar locking around vm_page_hold().  Although at present,
it won't trip an assertion.

Alan

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-scsi" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3E2710A2.97A2BB07>