Date: Fri, 28 May 2004 10:06:44 -0700 (PDT) From: Nate Lawson <nate@root.org> To: Tony Ackerman <tackerman@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files src/sys/dev/ixgb LICENSE README if_ixgb.c if_ixgb.h if_ixgb_osdep.h ixgb_ee.c ixgb_ee.h ixgb_hw.c ixgb_hw.h ixgb_ids.h src/sys/i386/conf GENERIC Message-ID: <20040528100234.M99072@root.org> In-Reply-To: <20040528002404.BDDB516A4D5@hub.freebsd.org> References: <20040528002404.BDDB516A4D5@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 27 May 2004, Tony Ackerman wrote:
> tackerman 2004/05/27 17:23:00 PDT
>
> FreeBSD src repository
>
> Modified files:
> sys/conf files
> sys/i386/conf GENERIC
> Added files:
> sys/dev/ixgb LICENSE README if_ixgb.c if_ixgb.h
> if_ixgb_osdep.h ixgb_ee.c ixgb_ee.h
> ixgb_hw.c ixgb_hw.h ixgb_ids.h
> sys/modules/ixgb Makefile
> Log:
> First release of ixgb driver for the Intel(R) PRO/10GbE Family of Adapters. This driver has
> been developed for use with FreeBSD, version 4.8 and later.
>
> Submitted by: Hema Joyce
> Reviewed by: Prafulla Deuskar
> Approved by: Prafulla Deuskar
> MFC after: 1 week
>
> Revision Changes Path
> 1.898 +3 -0 src/sys/conf/files
> 1.1 +29 -0 src/sys/dev/ixgb/LICENSE (new)
> 1.1 +238 -0 src/sys/dev/ixgb/README (new)
> 1.1 +2484 -0 src/sys/dev/ixgb/if_ixgb.c (new)
> 1.1 +385 -0 src/sys/dev/ixgb/if_ixgb.h (new)
> 1.1 +123 -0 src/sys/dev/ixgb/if_ixgb_osdep.h (new)
> 1.1 +781 -0 src/sys/dev/ixgb/ixgb_ee.c (new)
> 1.1 +117 -0 src/sys/dev/ixgb/ixgb_ee.h (new)
> 1.1 +1222 -0 src/sys/dev/ixgb/ixgb_hw.c (new)
> 1.1 +857 -0 src/sys/dev/ixgb/ixgb_hw.h (new)
> 1.1 +61 -0 src/sys/dev/ixgb/ixgb_ids.h (new)
> 1.405 +1 -0 src/sys/i386/conf/GENERIC
> 1.1 +11 -0 src/sys/modules/ixgb/Makefile (new)
Great! Good to have support for 10 GbE.
A couple comments... this driver appears to be developed under 4.x. How
well was it tested under 5.x? What are your plans for adding locking?
In general, please look at other FreeBSD drivers to get an idea for
locking style and other conventions.
> --- /dev/null Thu May 27 17:24:04 2004
> +++ src/sys/modules/ixgb/Makefile Thu May 27 17:23:00 2004
> @@ -0,0 +1,11 @@
> +#$FreeBSD: /repoman/r/ncvs/src/sys/modules/ixgb/Makefile,v 1.1 2004/05/28 00:23:00 tackerman Exp $
> +.PATH: ${.CURDIR}/../../dev/ixgb
> +KMOD = if_ixgb
> +SRCS = device_if.h bus_if.h pci_if.h opt_bdg.h
> +SRCS += if_ixgb.c ixgb_hw.c ixgb_ee.c
> +clean:
> + rm -f opt_bdg.h device_if.h bus_if.h pci_if.h setdef*
> + rm -f *.o *.kld *.ko
> + rm -f @ machine
> +
> +.include <bsd.kmod.mk>
The clean: line is unnecessary. Auto-generated files are auto-cleaned.
-Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040528100234.M99072>