Date: Fri, 3 Jun 2011 17:54:24 +0200 (CEST) From: Gerald Pfeifer <gerald@pfeifer.com> To: Ruslan Mahmatkhanov <cvs-src@yandex.ru> Cc: cvs-ports@FreeBSD.org, Wesley Shields <wxs@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/erlyvideo Makefile pkg-plist Message-ID: <alpine.LNX.2.00.1106031750420.3492@gerinyyl.fvgr> In-Reply-To: <4DE7FA38.2040307@yandex.ru> References: <201106021631.p52GVgHM038132@repoman.freebsd.org> <20110602165708.GA61311@atarininja.org> <4DE7D4B4.3040302@yandex.ru> <20110602195248.GA62894@atarininja.org> <4DE7FA38.2040307@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 3 Jun 2011, Ruslan Mahmatkhanov wrote: >>> I'm fully agree with that findelete stuff, so here is the patch, >>> thanks for pointing out. Surely i picked this construct in some >>> another port, but can't recall which one. > Here is complete (?) list of them - 112 ports: > http://pastebin.com/7abRca2h > > I can prepare patches if wish What's more important than that, I think, is addressing this in a more systematic manner to prevent new occurrences from slipping in: So I went ahead and filed PR ports/157566: portlint: Warng about use of ${FIND}...${XARGS} {RM}. Perhaps you can cook up a patch? :-) In my experience, the portlint maintainer is very responsive in making this kind of change or accepting/fixing proposed patches, and I encourage all of us doing it Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LNX.2.00.1106031750420.3492>