Date: Wed, 16 Nov 2011 04:44:11 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Eitan Adler <eadler@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/lang/s9fes Makefile Message-ID: <20111116044411.GA57332@FreeBSD.org> In-Reply-To: <201111160321.pAG3LYf3033418@repoman.freebsd.org> References: <201111160321.pAG3LYf3033418@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ibTvN161/egqYuK8 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline On Wed, Nov 16, 2011 at 03:21:34AM +0000, Eitan Adler wrote: > eadler 2011-11-16 03:21:34 UTC > > Modified files: > lang/s9fes Makefile > Log: > - mark port unsafe with -j Oh come on. Why blindly mark ports as -jX unsafe when trivial fix is discoverable in a minute? Also, REINPLACE_CMD's usage is very lame, and should be removed in favor of MAKE_ARGS. Please consider attached patch. ./danfe --ibTvN161/egqYuK8 Content-Type: text/plain; charset=koi8-r Content-Disposition: attachment; filename="s9.diff" Index: Makefile =================================================================== RCS file: /home/danfe/fbsd/FreeBSD-CVS/ports/lang/s9fes/Makefile,v retrieving revision 1.16 diff -u -r1.16 Makefile --- Makefile 9 Oct 2010 00:30:33 -0000 1.16 +++ Makefile 16 Nov 2011 04:42:26 -0000 @@ -13,13 +13,14 @@ MAINTAINER= nmh@t3x.org COMMENT= A portable Scheme interpreter with a Unix interface +MAKE_ARGS= PREFIX=${PREFIX} LIBDIR=${DATADIR} WRKSRC= ${WRKDIR}/s9 MAN1= s9.1 MANCOMPRESSED= yes post-patch: - ${REINPLACE_CMD} -e "s,PREFIX=.*,PREFIX=${PREFIX}," ${WRKSRC}/Makefile - ${REINPLACE_CMD} -e "s,LIBDIR=.*,LIBDIR=${DATADIR}," ${WRKSRC}/Makefile +# Fix parallel (-jX) build: add missing target prerequisite + @${REINPLACE_CMD} -e '/^arse-core.image/s,:,: s9,' ${WRKSRC}/Makefile .include <bsd.port.mk> --ibTvN161/egqYuK8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111116044411.GA57332>