Date: Sun, 7 Jul 2019 12:12:47 +0200 From: Matthias Fechner <idefix@fechner.net> To: freebsd-ports@freebsd.org Subject: Re: How to handle go dependencies Message-ID: <e1e4774d-8b9a-fdb3-4268-7c1cead99592@fechner.net> In-Reply-To: <20190706221001.GB86243@xombo.localdomain> References: <5d0e8e03.1c69fb81.5e249.9640@mx.google.com> <CAP7rwchtYTf5XPoTgk6B2drdPjzP%2B5opq-sN=kGsTJei6dT_Dg@mail.gmail.com> <20190622205205.GB40599@xombo.localdomain> <4de2a97c-8c41-74e4-cda1-4fdec9554e8f@fechner.net> <20190623095737.GA89814@urd.tobik.me> <d033ae4e-0d9c-183e-bd59-58117dde9460@fechner.net> <20190623214048.GE40599@xombo.localdomain> <07e99b4c-cf7e-49bb-d0a0-66a24c3a563f@fechner.net> <20190706194835.GA86243@xombo.localdomain> <52f3b04f-bf8d-0ec3-e3de-32c6d3a39485@fechner.net> <20190706221001.GB86243@xombo.localdomain>
next in thread | previous in thread | raw e-mail | index | archive | help
Dear Dmitri,
Am 07.07.2019 um 00:10 schrieb Dmitri Goutnik via freebsd-ports:
> It appears that Go build flags need to be passed down to `go build` invocation
> with MAKE_ENV:
>
> +MAKE_ENV= GOFLAGS="${GO_BUILDFLAGS}"
>
> With that change, the build then fails later due to missing statFileSystemType
> func definition for freebsd:
>
> # gitlab.com/gitlab-org/gitaly/internal/helper/fstype
> internal/helper/fstype/fstype.go:7:15: undefined: statFileSystemType
>
> Which can be fixed by just copying the linux version (this probably needs to
> be upstreamed):
>
> post-patch:
> ${REINPLACE_CMD} -e "s|%%PREFIX%%|${PREFIX}|" ${WRKSRC}/config.toml.example
> ${MV} ${WRKSRC}/config.toml.example ${WRKSRC}/config.toml.sample
> + ${CP} ${WRKSRC}/internal/helper/fstype/detect_linux.go ${WRKSRC}/internal/helper/fstype/detect_freebsd.go
thanks a lot for your help!
Without your help the upgrade to www/gitlab-ce 12.0.3 would not have
been possible.
This go stuff is really not that simple.
I reported the upstream change here:
https://gitlab.com/gitlab-org/gitaly/issues/1768
Gitlab-ce 12.0.3 is now commited ;)
Thanks again.
Gruß
Matthias
--
"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e1e4774d-8b9a-fdb3-4268-7c1cead99592>