Date: Sun, 27 Mar 2011 13:18:30 +0300 From: George Liaskos <geo.liaskos@gmail.com> To: Evan Martin <evan@chromium.org> Cc: freebsd-chromium@freebsd.org, "Y. A." <nexther0@gmail.com> Subject: Re: fixes for Makefile pkg-plist and build-in ffmpeg Message-ID: <BANLkTimn8joDX%2Bv3Zz%2BJ04p0SPQCKPeLOw@mail.gmail.com> In-Reply-To: <AANLkTimrOiK=e01-doqC8jJuOaXyZ6dni8Ngk8b1AmYK@mail.gmail.com> References: <AANLkTik5FbEcH8nB2SUtHNZYiLnaSVF1x1HmjcW0baO2@mail.gmail.com> <AANLkTimrOiK=e01-doqC8jJuOaXyZ6dni8Ngk8b1AmYK@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 27, 2011 at 11:28 AM, Evan Martin <evan@chromium.org> wrote: > Can you send the ffmpeg patch upstream? > > (Does ffmpeg/libavutil as upstream from Chrome build on FreeBSD?) There's an #if HAVE_MALLOC_H, malloc.h shouldn't be included. Do we really need the following patches? I compiled chrome without them, they include #define HAVE_MALLOC_H 0 which obviously doesn't affect anything. patch-third_party__ffmpeg__config__Chrome__freebsd__ia32__config.h patch-third_party__ffmpeg__config__Chrome__freebsd__x64__config.h patch-third_party__ffmpeg__config__Chromium__freebsd__ia32__config.h patch-third_party__ffmpeg__config__Chromium__freebsd__x64__config.h patch-third_party__ffmpeg__ffmpeg.gyp This should probably go and just add use_system_yasm=1 at GYP_DEFINES.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTimn8joDX%2Bv3Zz%2BJ04p0SPQCKPeLOw>