From owner-svn-src-head@FreeBSD.ORG Wed Nov 20 21:31:20 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E718A725; Wed, 20 Nov 2013 21:31:20 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C5F132B2A; Wed, 20 Nov 2013 21:31:20 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id rAKLVJ3J088184 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 20 Nov 2013 13:31:19 -0800 (PST) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id rAKLVJPd088183; Wed, 20 Nov 2013 13:31:19 -0800 (PST) (envelope-from jmg) Date: Wed, 20 Nov 2013 13:31:19 -0800 From: John-Mark Gurney To: Grzegorz Bernacki Subject: Re: svn commit: r258387 - head/sys/dev/nand Message-ID: <20131120213119.GL2279@funkthat.com> References: <201311201110.rAKBAOMY061212@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201311201110.rAKBAOMY061212@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Wed, 20 Nov 2013 13:31:20 -0800 (PST) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2013 21:31:21 -0000 Grzegorz Bernacki wrote this message on Wed, Nov 20, 2013 at 11:10 +0000: > Author: gber > Date: Wed Nov 20 11:10:23 2013 > New Revision: 258387 > URL: http://svnweb.freebsd.org/changeset/base/258387 > > Log: > Split raw reading/programming into smaller chunks to avoid allocating too > big chunk of kernel memory. Validate size of data. Add error handling to > avoid calling copyout() when data has not been read correctly. > > Reviewed by: zbb > Reported by: x90c > MFC after: 2 days > > Modified: > head/sys/dev/nand/nand_cdev.c > head/sys/dev/nand/nand_geom.c Looks like this change errors w/ gcc: http://tinderbox.freebsd.org/tinderbox-head-noclang-build-HEAD-armv6-arm.brief -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."