Date: Fri, 29 Apr 2011 08:26:53 -0400 (EDT) From: Rick Macklem <rmacklem@uoguelph.ca> To: "O. Hartmann" <ohartman@zedat.fu-berlin.de> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: CURRENT/amd64: kernel compil error: /usr/src/sys/fs/nfsclient/nfs_clvfsops.c: In function 'nfs_mount':, /usr/src/sys/fs/nfsclient/nfs_clvfsops.c:1030: warning: passing argument 4 of 'copyinstr' from incompatible pointer type Message-ID: <257816720.755191.1304080013911.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <4DBA8CA7.3060807@zedat.fu-berlin.de>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_755190_1581781352.1304080013909 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit > Since this morning after updating the sources I get the following > error > while compiling a new kernel: > > cc -c -O2 -frename-registers -pipe -fno-strict-aliasing -march=native > -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes > -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef > -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I/usr/src/sys > -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS > -include opt_global.h -fno-common -finline-limit=8000 --param > inline-unit-growth=100 --param large-function-growth=1000 > -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone -mfpmath=387 > -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -msoft-float > -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector > -Werror > /usr/src/sys/fs/nfsclient/nfs_clvfsops.c > cc1: warnings being treated as errors > /usr/src/sys/fs/nfsclient/nfs_clvfsops.c: In function 'nfs_mount': > /usr/src/sys/fs/nfsclient/nfs_clvfsops.c:1030: warning: passing > argument > 4 of 'copyinstr' from incompatible pointer type > *** Error code 1 > Oops, sorry. r221190 doesn't build for 64bits arches like amd64. I cribbed the code from the regular client, but didn't notice "len" was declared size_t and not int. The patch is attached and will be committed to head in a few minutes. Thanks for reporting it, rick ------=_Part_755190_1581781352.1304080013909 Content-Type: text/x-patch; name=sizet.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=sizet.patch LS0tIGZzL25mc2NsaWVudC9uZnNfY2x2ZnNvcHMuYy5zYXYJMjAxMS0wNC0yOSAwODoxMjo0Mi4w MDAwMDAwMDAgLTA0MDAKKysrIGZzL25mc2NsaWVudC9uZnNfY2x2ZnNvcHMuYwkyMDExLTA0LTI5 IDA4OjEzOjM1LjAwMDAwMDAwMCAtMDQwMApAQCAtNzYzLDYgKzc2Myw3IEBAIG5mc19tb3VudChz dHJ1Y3QgbW91bnQgKm1wKQogCWNoYXIgKm9wdCwgKm5hbWUsICpzZWNuYW1lOwogCWludCBuZWdu YW1ldGltZW8gPSBORlNfREVGQVVMVF9ORUdOQU1FVElNRU87CiAJaW50IGRpcmxlbiwgaGFzX25m c19hcmdzX29wdCwga3JibmFtZWxlbiwgc3J2a3JibmFtZWxlbjsKKwlzaXplX3QgaHN0bGVuOwog CiAJaGFzX25mc19hcmdzX29wdCA9IDA7CiAJaWYgKHZmc19maWx0ZXJvcHQobXAtPm1udF9vcHRu ZXcsIG5mc19vcHRzKSkgewpAQCAtMTAyNywxMCArMTAyOCwxMCBAQCBuZnNfbW91bnQoc3RydWN0 IG1vdW50ICptcCkKIAkJICAgIGFyZ3MuZmhzaXplKTsKIAkJaWYgKGVycm9yICE9IDApCiAJCQln b3RvIG91dDsKLQkJZXJyb3IgPSBjb3B5aW5zdHIoYXJncy5ob3N0bmFtZSwgaHN0LCBNTkFNRUxF TiAtIDEsICZsZW4pOworCQllcnJvciA9IGNvcHlpbnN0cihhcmdzLmhvc3RuYW1lLCBoc3QsIE1O QU1FTEVOIC0gMSwgJmhzdGxlbik7CiAJCWlmIChlcnJvciAhPSAwKQogCQkJZ290byBvdXQ7Ci0J CWJ6ZXJvKCZoc3RbbGVuXSwgTU5BTUVMRU4gLSBsZW4pOworCQliemVybygmaHN0W2hzdGxlbl0s IE1OQU1FTEVOIC0gaHN0bGVuKTsKIAkJYXJncy5ob3N0bmFtZSA9IGhzdDsKIAkJLyogc29ja2Fy Z3MoKSBjYWxsIG11c3QgYmUgYWZ0ZXIgYWJvdmUgY29weWluKCkgY2FsbHMgKi8KIAkJZXJyb3Ig PSBnZXRzb2NrYWRkcigmbmFtLCAoY2FkZHJfdClhcmdzLmFkZHIsCg== ------=_Part_755190_1581781352.1304080013909--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?257816720.755191.1304080013911.JavaMail.root>