From owner-freebsd-rc@FreeBSD.ORG  Sun Nov  4 13:40:11 2012
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 6B39CDD1
 for <freebsd-rc@FreeBSD.org>; Sun,  4 Nov 2012 13:40:11 +0000 (UTC)
 (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (unknown [IPv6:2001:610:1108:5012::107])
 by mx1.freebsd.org (Postfix) with ESMTP id 028958FC0A
 for <freebsd-rc@FreeBSD.org>; Sun,  4 Nov 2012 13:40:11 +0000 (UTC)
Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131])
 by mx1.stack.nl (Postfix) with ESMTP id 8A5851203C3;
 Sun,  4 Nov 2012 14:40:06 +0100 (CET)
Received: by snail.stack.nl (Postfix, from userid 1677)
 id 72EF82848C; Sun,  4 Nov 2012 14:40:06 +0100 (CET)
Date: Sun, 4 Nov 2012 14:40:06 +0100
From: Jilles Tjoelker <jilles@stack.nl>
To: Chris Rees <utisoft@gmail.com>
Subject: Re: conf/166484: [rc] [patch] rc.initdiskless patch for different
 major versions living together
Message-ID: <20121104134006.GA35520@stack.nl>
References: <201211041230.qA4CU1fT000866@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201211041230.qA4CU1fT000866@freefall.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-rc@FreeBSD.org
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
 <freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Nov 2012 13:40:11 -0000

On Sun, Nov 04, 2012 at 12:30:01PM +0000, Chris Rees wrote:
> The following reply was made to PR conf/166484; it has been noted by GNATS.

> From: Chris Rees <utisoft@gmail.com>
> To: "bug-followup@freebsd.org" <bug-followup@freebsd.org>
> Cc:  
> Subject: Re: conf/166484: [rc] [patch] rc.initdiskless patch for different
>  major versions living together
> Date: Sun, 4 Nov 2012 12:21:22 +0000

>  I think this is a great idea.

>  My only concern is the backslashitis in the finding of $rel, and also
>  the fact that it won't catch 10 properly :)

>  Instead of:

>  rel=`expr \`uname -r\` : '\(.\)'`

>  try:

>  rel=$(expr `uname -r` : '\([0-9][0-9]*\)')

>  Does anyone else have any opinions?

The shell command should be:

rel=$(uname -r)
rel=${rel%%.*}

Is it deliberate that the major release replaces base while the other
items like bcast/${ipba} and ip/${ip} add to it? I think so, with the
assumption that base.${rel} will be a straight copy of the results of
make installworld and make distribution with a DESTDIR, all local
changes living in the source tree or the other directories
rc.initdiskless uses.

-- 
Jilles Tjoelker