From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 13:15:55 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D133106566B for ; Sat, 24 Dec 2011 13:15:55 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 23B658FC0C for ; Sat, 24 Dec 2011 13:15:55 +0000 (UTC) Received: by iadj38 with SMTP id j38so19203195iad.13 for ; Sat, 24 Dec 2011 05:15:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=6pGtG4f7DzaCMysI4vnVc8bJwJAKDg8eox87hvx6ynU=; b=ZUt1fwIEirvpWPD7Qjukxe+6BxQ4U7Xbi2+LDOGzBXqsGpAmM0+IX9TedCy5qaTJ93 ufVvxtDi+0Yvig8HbYbLwMOuo+nr+Vf8KDkTXZdvY/WQ2txjfWUphG3lRKvRAshedFH3 Ouustbv61Dl9ImTTlSwbLqvlfcFCfsS3blEGw= Received: by 10.43.51.69 with SMTP id vh5mr21232988icb.32.1324732554280; Sat, 24 Dec 2011 05:15:54 -0800 (PST) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.30.70 with HTTP; Sat, 24 Dec 2011 05:15:23 -0800 (PST) In-Reply-To: <201112241230.pBOCUF3h064098@freefall.freebsd.org> References: <201112241230.pBOCUF3h064098@freefall.freebsd.org> From: Chris Rees Date: Sat, 24 Dec 2011 13:15:23 +0000 X-Google-Sender-Auth: OIM2dsmOtuOo9AZNUZwO5wd7LR4 Message-ID: To: Maxim Ignatenko Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-rc@freebsd.org Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and "disable" commands to rc.subr X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 13:15:55 -0000 On 24 December 2011 12:30, Maxim Ignatenko wrote: > The following reply was made to PR conf/163508; it has been noted by GNAT= S. > > From: Maxim Ignatenko > To: Doug Barton > Cc: bug-followup@freebsd.org > Subject: Re: conf/163508: [rc.subr] [patch] Add "enable" and > =A0"disable" commands to rc.subr > Date: Sat, 24 Dec 2011 14:20:19 +0200 > > =A0On 24 December 2011 04:15, Doug Barton wrote: > =A0> This idea has been considered before and rejected because it's too > =A0> difficult to catch all the corner cases, and actually editing a conf= ig > =A0> file is not really all that hard of a thing to do. > =A0> > > =A0The idea was to make enabling/disabling services less error-prone. It > =A0don't need to catch _all_ corner cases, because if administrator do > =A0something unusual with startup configuration he should be able to > =A0manipulate it in proper way, or even have tools that do something > =A0similar. > =A0Proposed patch handles /etc/rc.conf, /etc/rc.conf.local and > =A0/etc/rc.conf.d/* properly (I hope), so it should fit nicely in 95% of > =A0cases. > =A0Doing `service someserive enable` is much faster and less error-prone > =A0that `service someservice rcvar ; echo someservicercvar_enable=3DYES >= > > =A0/etc/rc.conf` Disagree, sorry. If we're going to implement these ideas we should do it properly, not for 95% of cases. Chris