Date: Thu, 01 Nov 2007 02:55:39 +0100 From: Christoph Mallon <christoph.mallon@gmx.de> To: Andrey Chernov <ache@nagual.pp.ru>, Alexey Dokuchaev <danfe@FreeBSD.ORG>, Juli Mallett <juli@clockworksquid.com>, src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/include _ctype.h Message-ID: <4729321B.8030809@gmx.de> In-Reply-To: <20071031223727.GB90994@nagual.pp.ru> References: <200710272232.l9RMWSbK072082@repoman.freebsd.org> <20071030200331.GA29309@toxic.magnesium.net> <20071031215526.GC89932@nagual.pp.ru> <20071031223349.GA552@FreeBSD.org> <20071031223727.GB90994@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrey Chernov wrote:
> On Wed, Oct 31, 2007 at 10:33:49PM +0000, Alexey Dokuchaev wrote:
>>> For ones who doubts there two tests compiled with -O2. As you may see the
>>> result is almost identical (andl vs cmpl):
>> Q.E.D. How about to restore original, more reader-friendly version then?
>
> 1. Reader-friendly version generates long code when absolutely no
> optimization used in compiler (for some reason f.e. to avoid optimization
> bugs).
Code with "absolutely no optimization" is slow for many other reasons.
> 2. It also breaks common style ctype using for is{w}ascii(). If revert
> this, is{w}ascii() should be rewritted too.
I think, the latter is a good suggestion.
Christoph
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4729321B.8030809>